sockets should not be pickleable

[pitrou]

BPO	11127
Nosy	@pitrou, @giampaolo, @IIIIllllIIIIllllIIIIllllIIIIllllIIIIll
Files	issue11127.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2011-03-20.22:59:12.686>
created_at = <Date 2011-02-05.08:30:26.032>
labels = ['type-bug', 'library']
title = 'sockets should not be pickleable'
updated_at = <Date 2011-03-20.22:59:12.684>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2011-03-20.22:59:12.684>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2011-03-20.22:59:12.686>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2011-02-05.08:30:26.032>
creator = 'pitrou'
dependencies = []
files = ['20803']
hgrepos = []
issue_num = 11127
keywords = ['patch']
message_count = 5.0
messages = ['127976', '128901', '128915', '131562', '131563']
nosy_count = 4.0
nosy_names = ['pitrou', 'giampaolo.rodola', 'xuanji', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue11127'
versions = ['Python 3.3']

[pitrou]

Like already done for file objects, sockets should refuse pickling by raising a TypeError.

[IIIIllllIIIIllllIIIIllllIIIIllllIIIIll]

the correct way is to provide a __getstate__ method for socket right? I have implemented that in the attached patch.

[pitrou]

You also need to a test to Lib/test/test_socket.py.

[python-dev]

New changeset 5e13e5e6df30 by Antoine Pitrou in branch 'default':
Issue bpo-11127: Raise a TypeError when trying to pickle a socket object.
http://hg.python.org/cpython/rev/5e13e5e6df30

[pitrou]

Committed the patch with the test, thank you!