fix_callable should be dropped from lib2to3 / changed

[SilentGhost]

BPO	11440
Nosy	@terryjreedy, @pitrou, @benjaminp, @ezio-melotti, @merwok, @florentx

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-01-09.14:12:41.177>
created_at = <Date 2011-03-08.16:08:07.535>
labels = ['type-bug', 'expert-2to3']
title = 'fix_callable should be dropped from lib2to3 / changed'
updated_at = <Date 2016-01-09.14:12:41.176>
user = 'https://bugs.python.org/SilentGhost'

bugs.python.org fields:

activity = <Date 2016-01-09.14:12:41.176>
actor = 'SilentGhost'
assignee = 'none'
closed = True
closed_date = <Date 2016-01-09.14:12:41.177>
closer = 'SilentGhost'
components = ['2to3 (2.x to 3.x conversion tool)']
creation = <Date 2011-03-08.16:08:07.535>
creator = 'SilentGhost'
dependencies = []
files = []
hgrepos = []
issue_num = 11440
keywords = []
message_count = 5.0
messages = ['130340', '130377', '130383', '146281', '146409']
nosy_count = 7.0
nosy_names = ['terry.reedy', 'pitrou', 'benjamin.peterson', 'ezio.melotti', 'eric.araujo', 'SilentGhost', 'flox']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue11440'
versions = ['Python 3.2', 'Python 3.3']

[SilentGhost]

Since the callable return in 3.2, should the fix_callable be dropped from lib2to3 or should it be adjusted to make distinction between 3.1 and 3.2 situation? I'm not sure if latter is possible.

[terryjreedy]

I suspect that this will not be the last time that a fix is version dependent. I think that the 2to3 distributed with 3.x should fix to 3.x. Otherwise, the fix would have to do an 'if version...' dance. (Perhaps the version distributed with 2.7 should do *that*.) But I would defer to those maintaining it.

[benjaminp]

Someone should probably ask python-dev. callable, of course, doesn't work in 3.1.

[florentx]

The decision should be left to the user.
IMHO, we could disable this automatic fixer.

[ezio-melotti]

Benjamin added a note in d9571fb37269.
I agree with Florent though, if the fixer is disabled by default and people are using 3.1 they will see the error and enable it.
If they aren't 2to3 will correctly leave callable().