Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The copy module already uses copyreg #55690

Closed
durban mannequin opened this issue Mar 13, 2011 · 6 comments
Closed

The copy module already uses copyreg #55690

durban mannequin opened this issue Mar 13, 2011 · 6 comments
Assignees
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@durban
Copy link
Mannequin

durban mannequin commented Mar 13, 2011

BPO 11481
Nosy @freddrake, @rhettinger, @ezio-melotti, @durban, @sandrotosi
Files
  • issue11481.patch
  • issue11481-v2.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ezio-melotti'
    closed_at = <Date 2012-11-08.09:07:21.785>
    created_at = <Date 2011-03-13.09:47:48.546>
    labels = ['type-feature', 'docs']
    title = 'The copy module already uses copyreg'
    updated_at = <Date 2014-03-24.18:57:04.843>
    user = 'https://github.com/durban'

    bugs.python.org fields:

    activity = <Date 2014-03-24.18:57:04.843>
    actor = 'hans-meine'
    assignee = 'ezio.melotti'
    closed = True
    closed_date = <Date 2012-11-08.09:07:21.785>
    closer = 'ezio.melotti'
    components = ['Documentation']
    creation = <Date 2011-03-13.09:47:48.546>
    creator = 'daniel.urban'
    dependencies = []
    files = ['22843', '22849']
    hgrepos = []
    issue_num = 11481
    keywords = ['patch']
    message_count = 6.0
    messages = ['130732', '141697', '141723', '175143', '175144', '214710']
    nosy_count = 8.0
    nosy_names = ['fdrake', 'rhettinger', 'ezio.melotti', 'daniel.urban', 'sandro.tosi', 'docs@python', 'python-dev', 'hans-meine']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue11481'
    versions = ['Python 2.7']

    @durban
    Copy link
    Mannequin Author

    durban mannequin commented Mar 13, 2011

    In the copyreg documentation there is this sentence: "The copy module is likely to use this in the future as well." (http://docs.python.org/dev/py3k/library/copyreg) But the copy module already uses the copyreg module.

    @durban durban mannequin assigned docspython Mar 13, 2011
    @durban durban mannequin added the docs Documentation in the Doc dir label Mar 13, 2011
    @sandrotosi
    Copy link
    Contributor

    A quick reword could be the one attached.

    @sandrotosi
    Copy link
    Contributor

    After quite a long chat with Ezio, I'm just proposing this updated patch:

    • it fixes the copy doc, explicitly acknowledging the use of copyreg functionalities
    • it rewords the first paragraph of copyreg doc, which was a bit too pickle-centric
    • it adds an example to copyreg, to give an initial clue of how it works.

    I'd like to hear comments/suggestions about it.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 8, 2012

    New changeset 2bd6150b48ea by Ezio Melotti in branch '2.7':
    bpo-11481: update copy_reg docs and add example.
    http://hg.python.org/cpython/rev/2bd6150b48ea

    New changeset e089bdca9d9c by Ezio Melotti in branch '2.7':
    bpo-11481: fix markup.
    http://hg.python.org/cpython/rev/e089bdca9d9c

    New changeset 12dbb3187105 by Ezio Melotti in branch '3.2':
    bpo-11481: update copyreg docs and add example.
    http://hg.python.org/cpython/rev/12dbb3187105

    New changeset 87ec3ce3a04e by Ezio Melotti in branch '3.3':
    bpo-11481: merge with 3.2.
    http://hg.python.org/cpython/rev/87ec3ce3a04e

    New changeset 20b65b88e0a0 by Ezio Melotti in branch 'default':
    bpo-11481: merge with 3.3.
    http://hg.python.org/cpython/rev/20b65b88e0a0

    @ezio-melotti
    Copy link
    Member

    I made a few minor changes and applied the patch.

    @ezio-melotti ezio-melotti added the type-feature A feature request or enhancement label Nov 8, 2012
    @hans-meine
    Copy link
    Mannequin

    hans-meine mannequin commented Mar 24, 2014

    Maybe some 2.7 backport is missing w.r.t. the documentation of the copy module? At least, http://docs.python.org/2/library/copy.html still states: "The copy module does not use the copy_reg registration module."

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants