Increase test coverage in dis module

[matiasb]

BPO	11559
Nosy	@ncoghlan, @benjaminp
Files	add_dis_tests.patch: Updates for test_dis tests updated_add_dis_tests.patch: Updated patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2011-03-15.19:43:45.882>
created_at = <Date 2011-03-15.18:50:26.016>
labels = ['type-bug', 'tests']
title = 'Increase test coverage in dis module'
updated_at = <Date 2011-03-15.19:43:45.881>
user = 'https://bugs.python.org/matiasb'

bugs.python.org fields:

activity = <Date 2011-03-15.19:43:45.881>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2011-03-15.19:43:45.882>
closer = 'python-dev'
components = ['Tests']
creation = <Date 2011-03-15.18:50:26.016>
creator = 'matiasb'
dependencies = []
files = ['21224', '21225']
hgrepos = []
issue_num = 11559
keywords = ['patch']
message_count = 4.0
messages = ['131018', '131021', '131024', '131029']
nosy_count = 4.0
nosy_names = ['ncoghlan', 'benjamin.peterson', 'python-dev', 'matiasb']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue11559'
versions = ['Python 3.3']

[matiasb]

Attaching patch to add new tests for dis module.

[benjaminp]

1. Use splitlines() instead of split('\n')
2. Use try finally when replacing sys.stdout.
3. Why is dist(None) a RuntimeError and anything else invalid TypeError?

[matiasb]

Updated patch following Benjamin advice (1. and 2.).

Re 3. Why is dist(None) a RuntimeError and anything else invalid TypeError?

When the dis argument is None, the last traceback is disassembled; if something different to None and that does not have code (ie. no class, method, function or bytecode) is passed, the TypeError exception is raised [0].

[0] http://hg.python.org/cpython/file/1c0cded97280/Lib/dis.py#l28

[python-dev]

New changeset f41c3d9e05bd by Benjamin Peterson in branch 'default':
improve dis test coverage (closes bpo-11559)
http://hg.python.org/cpython/rev/f41c3d9e05bd