Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand test coverage in shutil #55769

Closed
ev mannequin opened this issue Mar 15, 2011 · 2 comments
Closed

Expand test coverage in shutil #55769

ev mannequin opened this issue Mar 15, 2011 · 2 comments
Assignees
Labels
tests Tests in the Lib/test dir

Comments

@ev
Copy link
Mannequin

ev mannequin commented Mar 15, 2011

BPO 11560
Nosy @ncoghlan, @tarekziade
Files
  • increase_test_shutil_coverage.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ncoghlan'
    closed_at = <Date 2011-03-16.18:01:15.276>
    created_at = <Date 2011-03-15.21:31:48.635>
    labels = ['tests']
    title = 'Expand test coverage in shutil'
    updated_at = <Date 2011-03-16.18:01:15.274>
    user = 'https://bugs.python.org/ev'

    bugs.python.org fields:

    activity = <Date 2011-03-16.18:01:15.274>
    actor = 'python-dev'
    assignee = 'ncoghlan'
    closed = True
    closed_date = <Date 2011-03-16.18:01:15.276>
    closer = 'python-dev'
    components = ['Tests']
    creation = <Date 2011-03-15.21:31:48.635>
    creator = 'ev'
    dependencies = []
    files = ['21229']
    hgrepos = []
    issue_num = 11560
    keywords = ['patch']
    message_count = 2.0
    messages = ['131041', '131152']
    nosy_count = 4.0
    nosy_names = ['ncoghlan', 'tarek', 'python-dev', 'ev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue11560'
    versions = []

    @ev
    Copy link
    Mannequin Author

    ev mannequin commented Mar 15, 2011

    The attached patch increases the coverage in shutil. It makes the following changes:

    • Tests the code paths for file and directory copies across filesystems by mocking out rename.
    • Adds a test for shutil.copy.
    • Adds a test for shutil.copy2.
    • Tests shutil.unpack_archive with the format specified.
    • Tests the code path for creating the target directory in _make_tarball.

    I have tested this on Ubuntu natty and OSX 10.6.6. Note that this will fail until http://bugs.python.org/issue11548 is applied.

    @ev ev mannequin added the tests Tests in the Lib/test dir label Mar 15, 2011
    @ncoghlan ncoghlan self-assigned this Mar 16, 2011
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 16, 2011

    New changeset b313b05221a9 by Nick Coghlan in branch '3.2':
    Close bpo-11560: Improve test coverage of shutil
    http://hg.python.org/cpython/rev/b313b05221a9

    New changeset 5b61334bb776 by Nick Coghlan in branch 'default':
    Merge fix for bpo-11560 from 3.2
    http://hg.python.org/cpython/rev/5b61334bb776

    @python-dev python-dev mannequin closed this as completed Mar 16, 2011
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tests Tests in the Lib/test dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant