Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 2.5 does not build from hg - looks for subversion keywords #55788

Closed
orsenthil opened this issue Mar 17, 2011 · 5 comments
Closed

python 2.5 does not build from hg - looks for subversion keywords #55788

orsenthil opened this issue Mar 17, 2011 · 5 comments
Labels
build The build process and cross-build topic-installation

Comments

@orsenthil
Copy link
Member

BPO 11579
Nosy @loewis, @orsenthil, @bitdancer
Files
  • make-error.log
  • ignore_subversion_keywords.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2011-03-21.09:32:19.787>
    created_at = <Date 2011-03-17.04:27:09.859>
    labels = ['build', 'expert-installation']
    title = 'python 2.5 does not build from hg - looks for subversion keywords'
    updated_at = <Date 2011-03-21.09:32:19.785>
    user = 'https://github.com/orsenthil'

    bugs.python.org fields:

    activity = <Date 2011-03-21.09:32:19.785>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2011-03-21.09:32:19.787>
    closer = 'python-dev'
    components = ['Installation']
    creation = <Date 2011-03-17.04:27:09.859>
    creator = 'orsenthil'
    dependencies = []
    files = ['21259', '21260']
    hgrepos = []
    issue_num = 11579
    keywords = ['patch']
    message_count = 5.0
    messages = ['131216', '131269', '131299', '131334', '131624']
    nosy_count = 4.0
    nosy_names = ['loewis', 'orsenthil', 'r.david.murray', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue11579'
    versions = ['Python 2.5']

    @orsenthil
    Copy link
    Member Author

    Here is the make log and a patch to ignore looking for subversion keyword and assume some defaults (same is done in 2.6 + higher).

    @orsenthil orsenthil added topic-installation build The build process and cross-build labels Mar 17, 2011
    @smontanaro
    Copy link
    Contributor

    See bpo-11439.

    @orsenthil
    Copy link
    Member Author

    On Thu, Mar 17, 2011 at 05:16:43PM +0000, Skip Montanaro wrote:

    See bpo-11439.

    Yes, that is relevant and applies probably to code in default and
    other branches.
    Just in case, this corner case in 2.5 does not overlooked (because it
    does not happen in other branches), I think it is a good idea to keep
    this open and fix it with the patch attached in this issue.

    @bitdancer
    Copy link
    Member

    I talked to Martin about this at the sprints. He wants the set of patches in the 2.5 hg repo to be exactly those that he should apply to svn to build the next release, no more no less. If someone wants to propose a patch that fixes the hg compile but does not break the svn compile, he would find that acceptable. Alternatively the hg repo could be fixed, for our convenience, after 2.5 goes out of maintenance in November.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 21, 2011

    New changeset f9763c363cc3 by Martin v. Löwis in branch '2.5':
    Set subversion version identification to empty strings if this is not a subversion
    http://hg.python.org/cpython/rev/f9763c363cc3

    @python-dev python-dev mannequin closed this as completed Mar 21, 2011
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build topic-installation
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants