test_packaging failure

[pitrou]

BPO	12120
Nosy	@pitrou, @vstinner, @tarekziade, @merwok

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/merwok'
closed_at = <Date 2011-05-20.00:12:55.888>
created_at = <Date 2011-05-19.16:22:08.235>
labels = ['type-bug', 'tests']
title = 'test_packaging failure'
updated_at = <Date 2011-11-03.16:24:48.029>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2011-11-03.16:24:48.029>
actor = 'eric.araujo'
assignee = 'eric.araujo'
closed = True
closed_date = <Date 2011-05-20.00:12:55.888>
closer = 'vstinner'
components = ['Tests', 'Distutils2']
creation = <Date 2011-05-19.16:22:08.235>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 12120
keywords = []
message_count = 10.0
messages = ['136302', '136308', '136310', '136311', '136319', '136324', '136325', '136326', '136347', '146942']
nosy_count = 6.0
nosy_names = ['pitrou', 'vstinner', 'tarek', 'eric.araujo', 'alexis', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue12120'
versions = ['3rd party', 'Python 3.3']

[pitrou]

I get the following failure under a fresh checkout:

======================================================================
FAIL: test_package_data (packaging.tests.test_command_build_py.BuildPyTestCase)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/home/antoine/t/cpython/Lib/packaging/tests/test_command_build_py.py", line 64, in test_package_data
    self.assertIn("__init__.pyc", files)
AssertionError: '__init__.pyc' not found in ['README.txt', '__init__.py']

[tarekziade]

on it

[tarekziade]

I cannot reproduce this. there's exactly the same test in distutils, so I am wondering why it passes there and not in packaging for you.

Any special way to run the tests ?

[pitrou]

I cannot reproduce this. there's exactly the same test in distutils,
so I am wondering why it passes there and not in packaging for you.

It doesn't. Have you seen http://bugs.python.org/issue12119 ?

Any special way to run the tests ?

No. This is a fresh checkout on a fresh Linux install. Only zlib is
available (not bz2 etc.).

[pitrou]

This is due to PYTHONDONTWRITEBYTECODE being set. Not sure this is worth fixing.

[tarekziade]

a well, we can skip that pyc test in case PYTHONDONTWRITEBYTECODE is set, thanks !

[pitrou]

a well, we can skip that pyc test in case PYTHONDONTWRITEBYTECODE is set, thanks !

It's better to test sys.flags.dont_write_bytecode, actually.

[python-dev]

New changeset 9d1fb6a9104b by Tarek Ziade in branch 'default':
Issue bpo-12120, Issue bpo-12119: tests were missing a sys.dont_write_bytecode check
http://hg.python.org/cpython/rev/9d1fb6a9104b

[vstinner]

Duplicate of bpo-12117.

[merwok]

I have improved packaging to be independent of -B/-O in http://hg.python.org/cpython/rev/dad02a080bbc. See commit message for rationale.