Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify configure.in to detect OpenBSD 5.x #56801

Closed
rpointel mannequin opened this issue Jul 20, 2011 · 7 comments
Closed

modify configure.in to detect OpenBSD 5.x #56801

rpointel mannequin opened this issue Jul 20, 2011 · 7 comments

Comments

@rpointel
Copy link
Mannequin

rpointel mannequin commented Jul 20, 2011

BPO 12592
Nosy @pitrou
Files
  • configure_openbsd.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2011-07-22.21:56:24.518>
    created_at = <Date 2011-07-20.08:56:21.215>
    labels = ['expert-installation']
    title = 'modify configure.in to detect OpenBSD 5.x'
    updated_at = <Date 2011-07-22.21:56:24.516>
    user = 'https://bugs.python.org/rpointel'

    bugs.python.org fields:

    activity = <Date 2011-07-22.21:56:24.516>
    actor = 'neologix'
    assignee = 'none'
    closed = True
    closed_date = <Date 2011-07-22.21:56:24.518>
    closer = 'neologix'
    components = ['Installation']
    creation = <Date 2011-07-20.08:56:21.215>
    creator = 'rpointel'
    dependencies = []
    files = ['22720']
    hgrepos = []
    issue_num = 12592
    keywords = ['patch', 'needs review']
    message_count = 7.0
    messages = ['140724', '140906', '140907', '140914', '140915', '140916', '140917']
    nosy_count = 4.0
    nosy_names = ['pitrou', 'neologix', 'python-dev', 'rpointel']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue12592'
    versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

    @rpointel
    Copy link
    Mannequin Author

    rpointel mannequin commented Jul 20, 2011

    Hi,
    I tested to build Python 2.7 and Python 3.2.1 (it would be the same with others versions of Python) and it failed to build on OpenBSD 5.0 (beta version).

    This is the diff to correctly work on OpenBSD 5.x:

    --- configure.in.orig   Sat Jul  9 08:58:56 2011
    +++ configure.in        Wed Jul 20 10:19:37 2011
    @@ -320,7 +320,7 @@
         # As this has a different meaning on Linux, only define it on OpenBSD
         AC_DEFINE(_BSD_SOURCE, 1, [Define on OpenBSD to activate all library features])
         ;;
    -  OpenBSD/4.@<:@789@:>@)
    +  OpenBSD/4.@<:@789@:>@ | OpenBSD/5.*)
         # OpenBSD undoes our definition of __BSD_VISIBLE if _XOPEN_SOURCE is
         # also defined. This can be overridden by defining _BSD_SOURCE
         # As this has a different meaning on Linux, only define it on OpenBSD

    Could you add this modification in the different versions of Python ?

    Thanks a lot,

    Remi.

    @rpointel rpointel mannequin added the topic-installation label Jul 20, 2011
    @neologix
    Copy link
    Mannequin

    neologix mannequin commented Jul 22, 2011

    Patch attached (this one should also work with future major releases).

    @pitrou
    Copy link
    Member

    pitrou commented Jul 22, 2011

    Looks fine to me.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 22, 2011

    New changeset b24a2ccae56a by Charles-François Natali in branch '2.7':
    Issue bpo-12592: Make Python build on OpenBSD 5 (and future major releases).
    http://hg.python.org/cpython/rev/b24a2ccae56a

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 22, 2011

    New changeset 9c7f9d5841ff by Charles-François Natali in branch '3.2':
    Issue bpo-12592: Make Python build on OpenBSD 5 (and future major releases).
    http://hg.python.org/cpython/rev/9c7f9d5841ff

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 22, 2011

    New changeset 63de97ae832e by Charles-François Natali in branch 'default':
    Merge - Issue bpo-12592: Make Python build on OpenBSD 5 (and future major
    http://hg.python.org/cpython/rev/63de97ae832e

    @neologix
    Copy link
    Mannequin

    neologix mannequin commented Jul 22, 2011

    Patch committed.
    Rémi, thanks for reporting this (and other OpenBSD-specific bugs :-).

    @neologix neologix mannequin closed this as completed Jul 22, 2011
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant