Bug in http.client

[PCManticore]

BPO	12676
Nosy	@orsenthil, @merwok, @PCManticore
Files	issue12676_py33.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/orsenthil'
closed_at = <Date 2011-08-02.10:33:56.030>
created_at = <Date 2011-08-01.13:19:33.604>
labels = ['easy', 'type-bug', 'library']
title = 'Bug in http.client'
updated_at = <Date 2011-08-02.10:37:48.508>
user = 'https://github.com/PCManticore'

bugs.python.org fields:

activity = <Date 2011-08-02.10:37:48.508>
actor = 'orsenthil'
assignee = 'orsenthil'
closed = True
closed_date = <Date 2011-08-02.10:33:56.030>
closer = 'python-dev'
components = ['Library (Lib)']
creation = <Date 2011-08-01.13:19:33.604>
creator = 'Claudiu.Popa'
dependencies = []
files = ['22821']
hgrepos = []
issue_num = 12676
keywords = ['patch', 'easy']
message_count = 5.0
messages = ['141504', '141506', '141552', '141553', '141554']
nosy_count = 5.0
nosy_names = ['orsenthil', 'eric.araujo', 'santoso.wijaya', 'Claudiu.Popa', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue12676'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

[PCManticore]

There appears to be used a variable that is not defined in HTTPConnection.send method. The approximate line is 781. How to reproduce:
import http.client
import urllib.parse
c = urllib.parse.urlencode({"user":"claudiu", "password":"1"})
c = http.client.HTTPConnection("192.168.71.38")
c.request("POST", "test", c) # silly, I now.

There should be raised a TypeError here, but instead the error is:
File "C:\Python32\lib\http\client.py", line 781, in send
or an iterable, got %r " % type(it))
NameError: global name 'it' is not defined

[merwok]

It looks like “it” should be “data”.

[python-dev]

New changeset 1013c9fbd83c by Senthil Kumaran in branch '3.2':
Fix closes bpo-12676 - Invalid identifier used in TypeError message in http.client.
http://hg.python.org/cpython/rev/1013c9fbd83c

[python-dev]

New changeset c099ba0a278e by Senthil Kumaran in branch 'default':
Fix closes bpo-12676 - Invalid identifier used in TypeError message in http.client.
http://hg.python.org/cpython/rev/c099ba0a278e

[orsenthil]

Thanks for the bug report, Popa Claudiu and Patch Santoso Wijaya.
Ouch, pretty ugly bug - shows the code lacked test coverage.