Tests for Lib/xml/dom/minicompat.py

[JohnChandler]

BPO	12820
Nosy	@ezio-melotti, @sandrotosi, @phmc
Files	minicompat_tests.patch minicompat_tests_markedup.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ezio-melotti'
closed_at = <Date 2013-04-10.16:36:40.059>
created_at = <Date 2011-08-23.03:54:18.468>
labels = ['type-feature', 'tests']
title = 'Tests for Lib/xml/dom/minicompat.py'
updated_at = <Date 2013-04-10.16:36:40.057>
user = 'https://bugs.python.org/JohnChandler'

bugs.python.org fields:

activity = <Date 2013-04-10.16:36:40.057>
actor = 'ezio.melotti'
assignee = 'ezio.melotti'
closed = True
closed_date = <Date 2013-04-10.16:36:40.059>
closer = 'ezio.melotti'
components = ['Tests']
creation = <Date 2011-08-23.03:54:18.468>
creator = 'John.Chandler'
dependencies = []
files = ['23010', '29698']
hgrepos = []
issue_num = 12820
keywords = ['patch']
message_count = 7.0
messages = ['142779', '142861', '143007', '144078', '186167', '186516', '186517']
nosy_count = 5.0
nosy_names = ['ezio.melotti', 'sandro.tosi', 'John.Chandler', 'python-dev', 'pconnell']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue12820'
versions = ['Python 3.3', 'Python 3.4']

[JohnChandler]

The Lib/xml/dom/minicompat.py module doesn't appear to have any test coverage, probably because it's not the largest or most exciting of modules! :-) I therefore attach a patch to add test coverage for the EmptyNodeList and NodeList classes. I can add tests for the defproperty function if this patch proves acceptable.

The patch adds a new file (Lib/test/test_xml_dom_minicompat.py) and modifies one line of an existing file (Lib/test/xmltests.py)

I've used Python 3.3.0a0, courtesy of Brett's devinabox, but should be back-portable to older versions of Python.

[sandrotosi]

Hi, I just left a very light review on rietveld (the 'review' link below). I think in the next run you can add the tests for defproperty. Thanks for working on code coverage!

[JohnChandler]

Cool, thanks for the feedback! :-)

I'll make the appropriate changes to the tests and add some coverage for defproperty as soon as I can.

John

[JohnChandler]

Just to let you know I haven't forgotten this! I've been pretty busy recently so might be a while before I implement the changes to the patch suggested in the code review.

John

[phmc]

I happened to spot this issue languishing, and the markups looked pretty straightforward, so I just went ahead and did them.

Updated patch attached.

[python-dev]

New changeset 172f825d7fc9 by Ezio Melotti in branch '3.3':
bpo-12820: add tests for the xml.dom.minicompat module. Patch by John Chandler and Phil Connell.
http://hg.python.org/cpython/rev/172f825d7fc9

New changeset f675083b2894 by Ezio Melotti in branch 'default':
bpo-12820: merge with 3.3.
http://hg.python.org/cpython/rev/f675083b2894

[ezio-melotti]

Fixed, thanks for the patches!