Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peephole.c: unused parameter #57211

Closed
skrah mannequin opened this issue Sep 17, 2011 · 4 comments
Closed

peephole.c: unused parameter #57211

skrah mannequin opened this issue Sep 17, 2011 · 4 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@skrah
Copy link
Mannequin

skrah mannequin commented Sep 17, 2011

BPO 13002
Nosy @skrah, @meadori
Files
  • peephole_unused_parameter.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2011-09-21.20:08:34.543>
    created_at = <Date 2011-09-17.14:43:55.346>
    labels = ['interpreter-core', 'type-bug']
    title = 'peephole.c: unused parameter'
    updated_at = <Date 2011-09-21.20:08:34.542>
    user = 'https://github.com/skrah'

    bugs.python.org fields:

    activity = <Date 2011-09-21.20:08:34.542>
    actor = 'skrah'
    assignee = 'none'
    closed = True
    closed_date = <Date 2011-09-21.20:08:34.543>
    closer = 'skrah'
    components = ['Interpreter Core']
    creation = <Date 2011-09-17.14:43:55.346>
    creator = 'skrah'
    dependencies = []
    files = ['23183']
    hgrepos = []
    issue_num = 13002
    keywords = ['patch']
    message_count = 4.0
    messages = ['144189', '144200', '144384', '144389']
    nosy_count = 3.0
    nosy_names = ['skrah', 'meador.inge', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue13002'
    versions = ['Python 3.3']

    @skrah
    Copy link
    Mannequin Author

    skrah mannequin commented Sep 17, 2011

    peephole.c: CONST_STACK_TOP(x) has an unused parameter.

    @skrah skrah mannequin added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Sep 17, 2011
    @meadori
    Copy link
    Member

    meadori commented Sep 17, 2011

    Looks like it was checked in that way (http://hg.python.org/cpython/rev/14205d0fee45). Patch looks good to me.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 21, 2011

    New changeset 573d73e62bbc by Stefan Krah in branch 'default':
    Issue bpo-13002: Fix Visual Studio warning (not enough actual parameters).
    http://hg.python.org/cpython/rev/573d73e62bbc

    @skrah
    Copy link
    Mannequin Author

    skrah mannequin commented Sep 21, 2011

    Thanks for checking the patch! Closing this now.

    @skrah skrah mannequin closed this as completed Sep 21, 2011
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant