New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_Py_identifier should be _Py_IDENTIFER #57452
Comments
Looks like Parser/asdl_c.py did not get all the way updated when _Py_identifier switched over to _Py_IDENTIFER. I've included a patch that fixes it (though it's relatively trivial). With this fix I did not notice any further problems. |
Good catch. I see what happened. 7109f31300fb updated |
Oh, and just to be clear I reproduced the build break by doing: ./Parser/asdl_c.py -c ./Python ./Parser/Python.asdl in a built tree. The reason that this wasn't caught is that the make Maybe we should change the build system to always regenerate the files |
New changeset 941d015053c6 by Meador Inge in branch 'default': |
Committed. Thanks! |
Most definitely not. It is very deliberate that asdl_c.py is only |
OK, thanks for the background. To be clear, though, the build dependency # XXX Note that a build now requires Python exist before the build starts However, modifying the ASDL source is, with respect to other source
|
Am 23.10.2011 20:33, schrieb Meador Inge:
Just to be more clear: normally, generated files shouldn't be checked So when we check in generated files, the build dependency becomes unused
See above. It's fine to require core contributors to have Python |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: