Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdist_rpm: INSTALLED_FILES does not use __pycache__ #57516

Closed
skrah mannequin opened this issue Oct 31, 2011 · 6 comments
Closed

bdist_rpm: INSTALLED_FILES does not use __pycache__ #57516

skrah mannequin opened this issue Oct 31, 2011 · 6 comments
Assignees
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@skrah
Copy link
Mannequin

skrah mannequin commented Oct 31, 2011

BPO 13307
Nosy @pitrou, @merwok, @skrah

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/merwok'
closed_at = <Date 2011-11-03.01:52:08.046>
created_at = <Date 2011-10-31.22:38:37.063>
labels = ['tests', 'type-bug', 'library']
title = 'bdist_rpm: INSTALLED_FILES does not use __pycache__'
updated_at = <Date 2015-01-08.08:37:40.222>
user = 'https://github.com/skrah'

bugs.python.org fields:

activity = <Date 2015-01-08.08:37:40.222>
actor = 'Vjacheslav.Fyodorov'
assignee = 'eric.araujo'
closed = True
closed_date = <Date 2011-11-03.01:52:08.046>
closer = 'pitrou'
components = ['Distutils', 'Tests', 'Distutils2']
creation = <Date 2011-10-31.22:38:37.063>
creator = 'skrah'
dependencies = []
files = []
hgrepos = []
issue_num = 13307
keywords = []
message_count = 6.0
messages = ['146748', '146845', '146887', '146888', '146937', '233627']
nosy_count = 6.0
nosy_names = ['pitrou', 'eric.araujo', 'skrah', 'alexis', 'python-dev', 'Vjacheslav.Fyodorov']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue13307'
versions = ['Python 3.4']

@skrah
Copy link
Mannequin Author

skrah mannequin commented Oct 31, 2011

The failures seen on the Fedora buildbot are caused by the fact that
INSTALLED_FILES does not use __pycache__:

[stefan@fedora-14-i386 foo]$ cat build/bdist.linux-i686/rpm/BUILD/foo-0.1/INSTALLED_FILES
/usr/local/lib/python3.3/site-packages/foo.py
/usr/local/lib/python3.3/site-packages/foo.pyc
/usr/local/lib/python3.3/site-packages/foo.pyo
/usr/local/lib/python3.3/site-packages/foo-0.1-py3.3.egg-info

I'm not familiar with rpm, so I've no clue at which point this
file is generated.

@skrah skrah mannequin added tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Oct 31, 2011
@merwok
Copy link
Member

merwok commented Nov 2, 2011

bdist_rpm uses the record option of install to create INSTALLED_FILES.

install delegates to the get_output method of install_* commands to build its record.

install_lib has buggy code that appends 'c' or 'o' instead of using imp functions. I have expanded one test and successfully reproduced the bug; next I will fix the code.

@merwok merwok added the stdlib Python modules in the Lib dir label Nov 2, 2011
@merwok merwok changed the title test_bdist_rpm: INSTALLED_FILES does not use __pycache__ bdist_rpm: INSTALLED_FILES does not use __pycache__ Nov 2, 2011
@merwok merwok self-assigned this Nov 2, 2011
@python-dev
Copy link
Mannequin

python-dev mannequin commented Nov 3, 2011

New changeset 2c0253d4d9ba by Antoine Pitrou in branch '3.2':
Issue bpo-13307: fix bdist_rpm test failures
http://hg.python.org/cpython/rev/2c0253d4d9ba

New changeset eb2991f7cdc8 by Antoine Pitrou in branch 'default':
Issue bpo-13307: fix bdist_rpm test failures
http://hg.python.org/cpython/rev/eb2991f7cdc8

@pitrou
Copy link
Member

pitrou commented Nov 3, 2011

Should be fixed now (verified here on Mageia).

@pitrou pitrou closed this as completed Nov 3, 2011
@merwok
Copy link
Member

merwok commented Nov 3, 2011

I wrote the same fix this night :)

@VjacheslavFyodorov
Copy link
Mannequin

VjacheslavFyodorov mannequin commented Jan 8, 2015

Now in 3.4 Fedora 21

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants