Missing semicolon at Modules/posixsubprocess.c:4511

[nneonneo]

BPO	13339

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2011-11-04.06:41:20.098>
created_at = <Date 2011-11-04.04:34:23.841>
labels = ['extension-modules', 'build']
title = 'Missing semicolon at Modules/posixsubprocess.c:4511'
updated_at = <Date 2012-05-16.05:07:32.551>
user = 'https://bugs.python.org/nneonneo'

bugs.python.org fields:

activity = <Date 2012-05-16.05:07:32.551>
actor = 'python-dev'
assignee = 'rosslagerwall'
closed = True
closed_date = <Date 2011-11-04.06:41:20.098>
closer = 'rosslagerwall'
components = ['Extension Modules']
creation = <Date 2011-11-04.04:34:23.841>
creator = 'nneonneo'
dependencies = []
files = []
hgrepos = []
issue_num = 13339
keywords = []
message_count = 4.0
messages = ['146995', '146996', '146997', '160803']
nosy_count = 3.0
nosy_names = ['nneonneo', 'rosslagerwall', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue13339'
versions = ['Python 3.1', 'Python 3.2', 'Python 3.3', 'Python 3.4']

[nneonneo]

Line 4511 of Modules/posixsubprocess.c is missing a semicolon, so it would not compile successfully if the relevant build flags were enabled (PYOS_OS2).

Trivial patch:
@@ -4508,7 +4508,7 @@
 static PyObject *
 posix_spawnvpe(PyObject *self, PyObject *args)
 {
-    PyObject *opath
+    PyObject *opath;
     char *path;
     PyObject *argv, *env;
     char **argvlist;

No tests needed since it's a compile error.

[python-dev]

New changeset fa9c69dcf31b by Ross Lagerwall in branch '3.2':
Issue bpo-13339: Fix compile error in posixmodule.c due to missing semicolon.
http://hg.python.org/cpython/rev/fa9c69dcf31b

New changeset 9e5d14aadca4 by Ross Lagerwall in branch 'default':
(Merge 3.2) Issue bpo-13339.
http://hg.python.org/cpython/rev/9e5d14aadca4

[rosslagerwall]

Thanks!

[python-dev]

New changeset 91ac9c36f09e by Éric Araujo in branch 'default':
Harmonize error messages and add one missing test for bpo-13339
http://hg.python.org/distutils2/rev/91ac9c36f09e