mute ImportError in __del__ of _threading_local module

[ZhipingDeng]

BPO	13668
Nosy	@ezio-melotti, @tirkarthi
Files	_threading_local.mute_ImportError.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-03-19.12:00:44.818>
created_at = <Date 2011-12-28.13:18:12.401>
labels = []
title = 'mute ImportError in __del__ of _threading_local module'
updated_at = <Date 2019-03-19.12:00:44.817>
user = 'https://bugs.python.org/ZhipingDeng'

bugs.python.org fields:

activity = <Date 2019-03-19.12:00:44.817>
actor = 'xtreak'
assignee = 'none'
closed = True
closed_date = <Date 2019-03-19.12:00:44.818>
closer = 'xtreak'
components = []
creation = <Date 2011-12-28.13:18:12.401>
creator = 'Zhiping.Deng'
dependencies = []
files = ['24097']
hgrepos = []
issue_num = 13668
keywords = ['patch']
message_count = 3.0
messages = ['150288', '221878', '338346']
nosy_count = 3.0
nosy_names = ['ezio.melotti', 'Zhiping.Deng', 'xtreak']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue13668'
versions = ['Python 2.7']

[ZhipingDeng]

If python was configured without-threads:

% ./python
Python 2.7.2+ (2.7:e71e4bd45c89, Dec 28 2011, 21:03:59) 
[GCC 4.4.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import dummy_threading as _threading
>>> a = _threading.local()
>>> del a
Exception ImportError: ImportError('No module named thread',) in <bound method local.__del__ of <_threading_local.local object at 0xb7681694>> ignored

Patch to mute this Exception:
diff --git a/Lib/_threading_local.py b/Lib/_threading_local.py
--- a/Lib/_threading_local.py
+++ b/Lib/_threading_local.py
@@ -221,7 +221,13 @@
             lock.release()
 
     def __del__(self):
-        import threading
+        try:
+            import threading
+        except ImportError:
+            import sys
+            if '_dummy_threading' in sys.modules:
+                return
+            raise
 
         key = object.__getattribute__(self, '_local__key')

[BreamoreBoy]

Can this be closed as a result of bpo-9707 and r64543 ?

[tirkarthi]

As noted in msg221878 the import statement was removed and the original report is not reproducible in latest 2.7. Marking this as out of date. Thanks for the details.