Mercurial version information not appearing in Windows builds

[vsajip]

BPO	14093
Nosy	@loewis, @vsajip, @briancurtin
Files	build-info.diff: Changes to make_buildinfo.c to include Mercurial revision information

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-05-04.19:52:06.732>
created_at = <Date 2012-02-22.23:37:06.385>
labels = ['type-bug', 'OS-windows', 'build']
title = 'Mercurial version information not appearing in Windows builds'
updated_at = <Date 2012-05-04.19:52:06.730>
user = 'https://github.com/vsajip'

bugs.python.org fields:

activity = <Date 2012-05-04.19:52:06.730>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2012-05-04.19:52:06.732>
closer = 'python-dev'
components = ['Build', 'Windows']
creation = <Date 2012-02-22.23:37:06.385>
creator = 'vinay.sajip'
dependencies = []
files = ['24608']
hgrepos = []
issue_num = 14093
keywords = ['needs review']
message_count = 5.0
messages = ['154014', '154016', '159943', '159945', '159967']
nosy_count = 4.0
nosy_names = ['loewis', 'vinay.sajip', 'brian.curtin', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue14093'
versions = ['Python 3.3']

[vsajip]

Currently, the Mercurial revision information is not appearing in Windows builds - they always appear to be "default". This appears to be because the relevant information is not passed to getbuildinfo.c.

The attached patch rectifies this, making the assumption that "hg" will always be accessible on the path. The basic method is to call "hg id -bit" and then pass the branch, tag and revision information when compiling getbuildinfo.c.

If "hg" is not in the path, no Mercurial information is added (i.e. the current behaviour).

[vsajip]

Added Brian to nosy, as he said on IRC that he would look into my query about this.

[vsajip]

I'd like to commit this soon. Any chance of a review? It's a very small patch, so it shouldn't need much time.

[loewis]

Please go ahead and apply it.

[python-dev]

New changeset 4459d82ff127 by Vinay Sajip in branch 'default':
Closes bpo-14093: Added Mercurial version information to Windows builds.
http://hg.python.org/cpython/rev/4459d82ff127