Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_logging fails if zlib is not present #58464

Closed
ericvsmith opened this issue Mar 12, 2012 · 3 comments
Closed

test_logging fails if zlib is not present #58464

ericvsmith opened this issue Mar 12, 2012 · 3 comments
Assignees
Labels
easy tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@ericvsmith
Copy link
Member

BPO 14256
Nosy @ericvsmith
Files
  • issue14256.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ericvsmith'
    closed_at = <Date 2012-03-12.05:47:35.127>
    created_at = <Date 2012-03-12.01:24:16.450>
    labels = ['easy', 'type-bug', 'tests']
    title = 'test_logging fails if zlib is not present'
    updated_at = <Date 2012-03-12.05:47:35.125>
    user = 'https://github.com/ericvsmith'

    bugs.python.org fields:

    activity = <Date 2012-03-12.05:47:35.125>
    actor = 'python-dev'
    assignee = 'eric.smith'
    closed = True
    closed_date = <Date 2012-03-12.05:47:35.127>
    closer = 'python-dev'
    components = ['Tests']
    creation = <Date 2012-03-12.01:24:16.450>
    creator = 'eric.smith'
    dependencies = []
    files = ['24791']
    hgrepos = []
    issue_num = 14256
    keywords = ['patch', 'easy']
    message_count = 3.0
    messages = ['155425', '155430', '155443']
    nosy_count = 3.0
    nosy_names = ['eric.smith', 'python-dev', 'kroger']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue14256'
    versions = ['Python 3.3']

    @ericvsmith
    Copy link
    Member Author

    Presumably this needs to use requires_zlib.

    $ time ./python -m test test_logging
    [1/1] test_logging
    test test_logging crashed -- Traceback (most recent call last):
      File "/home/eric/local/python/cpython/Lib/test/regrtest.py", line 1229, in runtest_inner
        the_package = __import__(abstest, globals(), locals(), [])
      File "/home/eric/local/python/cpython/Lib/test/test_logging.py", line 49, in <module>
        import zlib
    ImportError: No module named 'zlib'

    1 test failed:
    test_logging
    [111665 refs]

    @ericvsmith ericvsmith added tests Tests in the Lib/test dir easy labels Mar 12, 2012
    @kroger
    Copy link
    Mannequin

    kroger mannequin commented Mar 12, 2012

    Attached patch to fix this issue.

    @ericvsmith ericvsmith self-assigned this Mar 12, 2012
    @ericvsmith ericvsmith added the type-bug An unexpected behavior, bug, or error label Mar 12, 2012
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 12, 2012

    New changeset 4b54a686541f by Eric V. Smith in branch 'default':
    Make test_logging no longer fail if zlib not present. Closes bpo-14256. Patch by Pedro Kroger.
    http://hg.python.org/cpython/rev/4b54a686541f

    @python-dev python-dev mannequin closed this as completed Mar 12, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    easy tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant