Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy_bypass_macosx_sysconf does not handle singel ip addresses correctly #58537

Closed
SergeDroz mannequin opened this issue Mar 15, 2012 · 2 comments
Closed

proxy_bypass_macosx_sysconf does not handle singel ip addresses correctly #58537

SergeDroz mannequin opened this issue Mar 15, 2012 · 2 comments
Assignees
Labels
OS-mac type-bug An unexpected behavior, bug, or error

Comments

@SergeDroz
Copy link
Mannequin

SergeDroz mannequin commented Mar 15, 2012

BPO 14329
Nosy @ronaldoussoren
Files
  • urllib_macos.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ronaldoussoren'
    closed_at = <Date 2012-10-15.07:52:48.837>
    created_at = <Date 2012-03-15.22:49:13.759>
    labels = ['OS-mac', 'type-bug']
    title = 'proxy_bypass_macosx_sysconf does not handle singel ip addresses correctly'
    updated_at = <Date 2012-10-15.07:52:48.836>
    user = 'https://bugs.python.org/SergeDroz'

    bugs.python.org fields:

    activity = <Date 2012-10-15.07:52:48.836>
    actor = 'ronaldoussoren'
    assignee = 'ronaldoussoren'
    closed = True
    closed_date = <Date 2012-10-15.07:52:48.837>
    closer = 'ronaldoussoren'
    components = ['macOS']
    creation = <Date 2012-03-15.22:49:13.759>
    creator = 'Serge.Droz'
    dependencies = []
    files = ['24880']
    hgrepos = []
    issue_num = 14329
    keywords = ['patch']
    message_count = 2.0
    messages = ['155973', '168649']
    nosy_count = 2.0
    nosy_names = ['ronaldoussoren', 'Serge.Droz']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = None
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue14329'
    versions = ['Python 2.6']

    @SergeDroz
    Copy link
    Mannequin Author

    SergeDroz mannequin commented Mar 15, 2012

    On MacOS in urllib the function proxy_bypass_macosx_sysconf does not handle proxy settings which are just IP addresses correctly:
    If there is any IP address, always true is reported.

    Reason: the mask is calculated wrong.
    The attached patch fixes this.

    NB This is also an issue in other python versions

    @SergeDroz SergeDroz mannequin added the OS-mac label Mar 15, 2012
    @ronaldoussoren
    Copy link
    Contributor

    Patch seems to be present in the current maintenance and development releases (2.7, 3.2 and 3.3).

    Can you confirm that this issue is no longer present in python 2.7 and later?

    @ronaldoussoren ronaldoussoren added the type-bug An unexpected behavior, bug, or error label Aug 29, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    OS-mac type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant