Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent refleaks #58545

Closed
skrah mannequin opened this issue Mar 16, 2012 · 6 comments
Closed

Recent refleaks #58545

skrah mannequin opened this issue Mar 16, 2012 · 6 comments
Labels
performance Performance or resource usage tests Tests in the Lib/test dir

Comments

@skrah
Copy link
Mannequin

skrah mannequin commented Mar 16, 2012

BPO 14337
Nosy @benjaminp, @skrah

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-03-17.10:44:13.231>
created_at = <Date 2012-03-16.19:32:03.365>
labels = ['tests', 'performance']
title = 'Recent refleaks'
updated_at = <Date 2012-03-17.10:44:13.230>
user = 'https://github.com/skrah'

bugs.python.org fields:

activity = <Date 2012-03-17.10:44:13.230>
actor = 'skrah'
assignee = 'none'
closed = True
closed_date = <Date 2012-03-17.10:44:13.231>
closer = 'skrah'
components = ['Tests']
creation = <Date 2012-03-16.19:32:03.365>
creator = 'skrah'
dependencies = []
files = []
hgrepos = []
issue_num = 14337
keywords = []
message_count = 6.0
messages = ['156071', '156072', '156078', '156104', '156116', '156152']
nosy_count = 2.0
nosy_names = ['benjamin.peterson', 'skrah']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue14337'
versions = ['Python 3.3']

@skrah
Copy link
Mannequin Author

skrah mannequin commented Mar 16, 2012

I don't see immediately why, but since 3877bf2e323 test_builtin and
a couple of other tests leak in refcounting mode:

hg up 8a5742b7a14d
make distclean && ./configure --with-pydebug && make
./python -m test -uall -R :: test_builtin
[1/1] test_builtin
beginning 9 repetitions
123456789
.........
1 test OK.
[154630 refs]

hg up 3877bf2e323
make distclean && ./configure --with-pydebug && make
./python -m test -uall -R :: test_builtin
[1/1] test_builtin
beginning 9 repetitions
123456789
.........
test_builtin leaked [880, 880, 880, 880] references, sum=3520
1 test failed:
test_builtin
[163380 refs]

@skrah skrah mannequin added tests Tests in the Lib/test dir performance Performance or resource usage labels Mar 16, 2012
@benjaminp
Copy link
Contributor

Yes, see 9e7f6ddc0d76 for the fix.

@skrah
Copy link
Mannequin Author

skrah mannequin commented Mar 16, 2012

Ah, thanks for the pointer. 9e7f6ddc0d76 is clean, but default still
leaks. Next attempt:

OK: d2460ff173ff
Leak: 3b2856d8614b

test_dict leaked [12, 12] references, sum=24
test_builtin leaked [24, 24] references, sum=48
test_unittest leaked [970, 970] references, sum=1940
test_doctest leaked [351, 351] references, sum=702
test_doctest2 leaked [50, 50] references, sum=100

@skrah skrah mannequin reopened this Mar 16, 2012
@skrah skrah mannequin changed the title test_builtin: refleaks Recent refleaks Mar 16, 2012
@benjaminp
Copy link
Contributor

Okay, hopefuly fixed now.

@benjaminp
Copy link
Contributor

I think I've nailed them all now.

@skrah
Copy link
Mannequin Author

skrah mannequin commented Mar 17, 2012

Nice. 0554183066b5 is completely clean except for a leak in
test_curses. I think that one may be due to the fact that I'm
running the tests in an ssh terminal.

@skrah skrah mannequin closed this as completed Mar 17, 2012
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance or resource usage tests Tests in the Lib/test dir
Projects
None yet
Development

No branches or pull requests

1 participant