Have importlib use return value from a loader's load_module()

[brettcannon]

BPO	14582
Nosy	@brettcannon, @ericsnowcurrently

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/brettcannon'
closed_at = <Date 2012-04-15.19:25:55.317>
created_at = <Date 2012-04-14.20:31:40.515>
labels = ['interpreter-core', 'performance']
title = "Have importlib use return value from a loader's load_module()"
updated_at = <Date 2012-04-18.14:55:51.991>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2012-04-18.14:55:51.991>
actor = 'python-dev'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2012-04-15.19:25:55.317>
closer = 'brett.cannon'
components = ['Interpreter Core']
creation = <Date 2012-04-14.20:31:40.515>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 14582
keywords = []
message_count = 4.0
messages = ['158280', '158284', '158356', '158629']
nosy_count = 3.0
nosy_names = ['brett.cannon', 'python-dev', 'eric.snow']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue14582'
versions = ['Python 3.3']

[brettcannon]

Right now importlib doesn't use what loader.load_module() returns as that was what import.c did. But PEP-302 explicitly states that load_module() is expected to return the module that was loaded. So to save a dict lookup I want to rely on the return value of load_module().

[ericsnowcurrently]

big +1! I went quite a while before realizing that loader.load_module() was supposed to return the module, due to this specific issue.

[python-dev]

New changeset 005fd1fe31ab by Brett Cannon in branch 'default':
Issue bpo-14582: Import returns the module returned by a loader instead
http://hg.python.org/cpython/rev/005fd1fe31ab

[python-dev]

New changeset db5e3431ee4c by Benjamin Peterson in branch 'default':
rollback 005fd1fe31ab (see bpo-14609 and bpo-14582)
http://hg.python.org/cpython/rev/db5e3431ee4c