New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools/parser/unparse.py is out of date. #58900
Comments
Here's a patch that makes all tests in Tools/parser/test_unparse.py pass on the default branch. (The 'yield from' bits would have to be removed for 3.2.) |
There is a test_tools file now. test_unparse could be called from it. |
Ah, that's good to know. I think I'll commit the fix and then look into hooking test_unparse into test_tools. For 3.2, it turns out that all that's missing is support for Starred. |
Committed in revision c80576303892 (3.2), revision 89e928048903 (default). (I put 14965 instead of 14695 in the commit messages by mistake.) |
David: Any suggestions for how best to integrate test_unparse.py into test_tools? We could move the contents of test_unparse.py directly in test_tools.py and just kill the old test_unparse.py. Alternatively, we could import those TestCase subclasses from test_unparse; is there a better way of doing this than temporarily hacking sys.path to add the Tools/parser directory, as in the attached patch? |
Since we are already doing path hackery in that test file to get things to run, I think your patch would be fine. If we grow more tests for the stuff in Tools (which would be good), we might want to consider reorganizing things, but for now I think that the simplest thing that works is good. |
New changeset f9344a3eaaa6 by Mark Dickinson in branch 'default': |
Thanks, David! |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: