Add HTTP status codes introduced by RFC 6585

[EungJunYi]

BPO	14809
Nosy	@orsenthil, @hynek
Files	rfc6585.patch rfc6585-rev2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-05-16.09:38:42.448>
created_at = <Date 2012-05-14.18:01:11.550>
labels = ['type-feature', 'library']
title = 'Add HTTP status codes introduced by RFC 6585'
updated_at = <Date 2012-05-16.09:38:42.447>
user = 'https://bugs.python.org/EungJunYi'

bugs.python.org fields:

activity = <Date 2012-05-16.09:38:42.447>
actor = 'hynek'
assignee = 'none'
closed = True
closed_date = <Date 2012-05-16.09:38:42.448>
closer = 'hynek'
components = ['Library (Lib)']
creation = <Date 2012-05-14.18:01:11.550>
creator = 'EungJun.Yi'
dependencies = []
files = ['25582', '25597']
hgrepos = []
issue_num = 14809
keywords = ['patch']
message_count = 6.0
messages = ['160651', '160652', '160717', '160732', '160816', '160820']
nosy_count = 4.0
nosy_names = ['orsenthil', 'python-dev', 'EungJun.Yi', 'hynek']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue14809'
versions = ['Python 3.3']

[EungJunYi]

This patch add HTTP status codes introduced by RFC 6585, to http.client and http.server.

428 Precondition Required
429 Too Many Requests
431 Request Header Fields Too Large
511 Network Authentication Required

[hynek]

I've cross-checked the patch against the RFC and it LGTM. Tests still pass as expected.

[hynek]

EungYun,

After further research I've found two issue which you should fix before it can be checked in:

• The multi-line strings are missing spaces at their line break (429 and 431).
• The error codes are documented at http://hg.python.org/cpython/file/26b8ec8a7800/Doc/library/http.client.rst#l180 , so you should add the new ones there.
• You should mention the new RFC at Lib/http/server.py#l576 .

Would you like to update your patch?

[EungJunYi]

Hynek, I have fixed them and upload the patch, rfc6585-rev2.patch.

[python-dev]

New changeset 981aabe6ea2f by Hynek Schlawack in branch 'default':
bpo-14809: Add HTTP status codes from RFC 6585 to http.server and http.client
http://hg.python.org/cpython/rev/981aabe6ea2f

[hynek]

Thank you for your contribution to Python, EungJun!

Just two small remarks:

• Please sign and submit the contributor form from http://www.python.org/psf/contrib/ . You'll get a nice star next to your name in return. :)
• I have fixed the flow of one of the lines. It's no big deal, but PEP-8 asks for a max line length of 79 characters.