stdlib compatibility with pypy: mailbox module

[mattip]

BPO	15040
Nosy	@warsaw, @amauryfa, @bitdancer, @akheron, @mattip
Files	mailbox.patch mailbox.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-10-23.12:04:28.635>
created_at = <Date 2012-06-09.19:26:19.998>
labels = ['type-bug', 'library', 'expert-email']
title = 'stdlib compatibility with pypy: mailbox module'
updated_at = <Date 2012-10-23.12:04:28.634>
user = 'https://github.com/mattip'

bugs.python.org fields:

activity = <Date 2012-10-23.12:04:28.634>
actor = 'petri.lehtinen'
assignee = 'none'
closed = True
closed_date = <Date 2012-10-23.12:04:28.635>
closer = 'petri.lehtinen'
components = ['Library (Lib)', 'email']
creation = <Date 2012-06-09.19:26:19.998>
creator = 'mattip'
dependencies = []
files = ['25869', '25937']
hgrepos = []
issue_num = 15040
keywords = ['patch']
message_count = 10.0
messages = ['162564', '162566', '162567', '162607', '162635', '162636', '162754', '162781', '173596', '173598']
nosy_count = 6.0
nosy_names = ['barry', 'amaury.forgeotdarc', 'r.david.murray', 'python-dev', 'petri.lehtinen', 'mattip']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue15040'
versions = ['Python 2.7']

[mattip]

These are changes necessary to mailbox.py and its tests so that tests pass (windows platform) on pypy 1.9.0. Files must be explicitly closed on pypy.

I would like to submit these as a "compatability" issue type, but that category does not exist, so I used "behavior".

This is the first in a series of a number of such patches, I think there will be about 20.

[bitdancer]

I see some code changes, but no added tests for those code changes.

msg.fp doesn't exist in Python3. I'd like to understand those changes better, but I don't know when I'll have the time or if it is worth the effort.

[bitdancer]

Oh, and the code changes should presumably be applied to Python3 as well (once there are tests), so I've added those versions. It might be better to have two patches, one for the close of _file, and the other for the msg.fp stuff (since that doesn't exist in Python3).

[amauryfa]

I'm not sure about the __del__: if pypy's deferred garbage collection is not enough to close self._file, how can a __del__ method help?

[mattip]

Revised patch: changes to mailbox.py were not needed for pypy. Someone did a good job with mailbox.py in stdlib 2.7.3

Now the patch only changes tests. The tests in 3.3 are very different, it seems to me there is little that can be reused there.

[bitdancer]

Ah, good. I thought we'd fixed the open/close issues, but I could easily believe we had missed something (especially in Python2).

Since the fp stuff is gone in 3, I'd be OK with just applying this.

[mattip]

What is the next stage in moving this forward? I am new here...

[bitdancer]

You could get one of the pypy devs that have push rights on cpython to commit it. If that doesn't happen, then at some point (probably not *too* long from now) I or someone else will commit it. We have many more patches than we have people with time to commit them, so it sometimes takes a bit.

[python-dev]

New changeset 84cd07899baf by Petri Lehtinen in branch '2.7':
bpo-15040: Close files in mailbox tests for PyPy compatibility
http://hg.python.org/cpython/rev/84cd07899baf

[akheron]

Applied, thanks!