Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright/licensing statement in new venv module #59378

Closed
merwok opened this issue Jun 24, 2012 · 2 comments
Closed

Copyright/licensing statement in new venv module #59378

merwok opened this issue Jun 24, 2012 · 2 comments
Assignees
Labels
stdlib Python modules in the Lib dir

Comments

@merwok
Copy link
Member

merwok commented Jun 24, 2012

BPO 15173
Nosy @vsajip, @merwok
Files
  • venv-licensing.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/vsajip'
    closed_at = <Date 2012-06-24.23:47:55.706>
    created_at = <Date 2012-06-24.20:32:39.069>
    labels = ['library']
    title = 'Copyright/licensing statement in new venv module'
    updated_at = <Date 2012-06-24.23:47:55.705>
    user = 'https://github.com/merwok'

    bugs.python.org fields:

    activity = <Date 2012-06-24.23:47:55.705>
    actor = 'python-dev'
    assignee = 'vinay.sajip'
    closed = True
    closed_date = <Date 2012-06-24.23:47:55.706>
    closer = 'python-dev'
    components = ['Library (Lib)']
    creation = <Date 2012-06-24.20:32:39.069>
    creator = 'eric.araujo'
    dependencies = []
    files = ['26135']
    hgrepos = []
    issue_num = 15173
    keywords = ['patch']
    message_count = 2.0
    messages = ['163850', '163876']
    nosy_count = 3.0
    nosy_names = ['vinay.sajip', 'eric.araujo', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue15173'
    versions = ['Python 3.3']

    @merwok
    Copy link
    Member Author

    merwok commented Jun 24, 2012

    While reading the venv source I noticed a typo in the copyright/license line (“20011”); I propose a patch that removes that line in favor of the customary “Licensed to the PSF” line, which is IMO much clearer (I never understand what the combination of “all rights reserved” and a free software license means). I have added a comment to preserve the mention of your authorship (as well as a reference to virtualenv’s authors, which sounds fair to me—but maybe it’s good enough that the PEP mention them). I do hope this does not seem disrespectful to you; I really appreciate your work and don’t wish to diminish your merit, but I think the notice is strange and should be fixed.

    Another minor edit in the diff is the removal of an obsolete mention of pythonv; could be another commit if you prefer.

    @merwok merwok added the stdlib Python modules in the Lib dir label Jun 24, 2012
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jun 24, 2012

    New changeset c96dd645825e by Vinay Sajip in branch 'default':
    Closes bpo-15173: Tidied up copyright statements and removed pythonv references.
    http://hg.python.org/cpython/rev/c96dd645825e

    @python-dev python-dev mannequin closed this as completed Jun 24, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants