stringification of subclasses of OSError can cause crash

[sbt]

BPO	15229
Nosy	@pitrou

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-06-30.21:39:08.495>
created_at = <Date 2012-06-30.20:09:41.869>
labels = ['interpreter-core', 'type-crash']
title = 'stringification of subclasses of OSError can cause crash'
updated_at = <Date 2012-06-30.21:39:08.493>
user = 'https://bugs.python.org/sbt'

bugs.python.org fields:

activity = <Date 2012-06-30.21:39:08.493>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2012-06-30.21:39:08.495>
closer = 'pitrou'
components = ['Interpreter Core']
creation = <Date 2012-06-30.20:09:41.869>
creator = 'sbt'
dependencies = []
files = []
hgrepos = []
issue_num = 15229
keywords = []
message_count = 4.0
messages = ['164423', '164426', '164427', '164428']
nosy_count = 3.0
nosy_names = ['pitrou', 'python-dev', 'sbt']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue15229'
versions = ['Python 3.3']

[sbt]

If you subclass OSError without calling OSError.__init__() then you can get a crash. For example

  Python 3.3.0b1 (default:cfbe51e66749, Jun 30 2012, 20:50:54) [MSC v.1600 32 bit
  (Intel)] on win32
  Type "help", "copyright", "credits" or "license" for more information.
  >>> class MyError(OSError):
  ...   def __init__(self):
  ...     pass
  ...
  [61116 refs]
  >>> repr(MyError())
  Assertion failed: obj, file ..\Objects\unicodeobject.c, line 2646

Note that str(MyError()) results in a crash without hitting a failed assertion.

The problem does not occur in Python 3.2, and it does not affect subclasses of Exception.

[pitrou]

Here is a quick patch (needs a test):

diff --git a/Objects/exceptions.c b/Objects/exceptions.c
--- a/Objects/exceptions.c
+++ b/Objects/exceptions.c
@@ -834,6 +834,7 @@ oserror_init(PyOSErrorObject *self, PyOb
 #endif
 
     /* Steals the reference to args */
+    Py_CLEAR(self->args);
     self->args = args;
     args = NULL;
 
@@ -916,6 +917,11 @@ OSError_new(PyTypeObject *type, PyObject
             ))
             goto error;
     }
+    else {
+        self->args = PyTuple_New(0);
+        if (self->args == NULL)
+            goto error;
+    }
 
     return (PyObject *) self;

[python-dev]

New changeset 1cbab581bf1e by Antoine Pitrou in branch 'default':
Issue bpo-15229: An OSError subclass whose __init__ doesn't call back
http://hg.python.org/cpython/rev/1cbab581bf1e

[pitrou]

It should be fixed now.