Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource leak in support.py:_is_ipv6_enabled #59482

Closed
bbrazil mannequin opened this issue Jul 7, 2012 · 4 comments
Closed

Fix resource leak in support.py:_is_ipv6_enabled #59482

bbrazil mannequin opened this issue Jul 7, 2012 · 4 comments
Labels
performance Performance or resource usage tests Tests in the Lib/test dir

Comments

@bbrazil
Copy link
Mannequin

bbrazil mannequin commented Jul 7, 2012

BPO 15277
Files
  • ipv6-enabled-fd-leak-fix.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2012-07-07.16:47:15.558>
    created_at = <Date 2012-07-07.14:16:01.842>
    labels = ['tests', 'performance']
    title = 'Fix resource leak in support.py:_is_ipv6_enabled'
    updated_at = <Date 2012-07-07.16:49:09.363>
    user = 'https://bugs.python.org/bbrazil'

    bugs.python.org fields:

    activity = <Date 2012-07-07.16:49:09.363>
    actor = 'rosslagerwall'
    assignee = 'rosslagerwall'
    closed = True
    closed_date = <Date 2012-07-07.16:47:15.558>
    closer = 'rosslagerwall'
    components = ['Tests']
    creation = <Date 2012-07-07.14:16:01.842>
    creator = 'bbrazil'
    dependencies = []
    files = ['26299']
    hgrepos = []
    issue_num = 15277
    keywords = ['patch']
    message_count = 4.0
    messages = ['164855', '164907', '164908', '164910']
    nosy_count = 3.0
    nosy_names = ['bbrazil', 'rosslagerwall', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'resource usage'
    url = 'https://bugs.python.org/issue15277'
    versions = ['Python 3.3']

    @bbrazil
    Copy link
    Mannequin Author

    bbrazil mannequin commented Jul 7, 2012

    I'm running Ubuntu Precise and have net.ipv6.conf.all.disable_ipv6 = 1 in my sysctl.conf. With this configuration at head there's a fd leak in
    _is_ipv6_enabled in support.py when the bind fails, which the attached patch should fix.

    @bbrazil bbrazil mannequin added tests Tests in the Lib/test dir performance Performance or resource usage labels Jul 7, 2012
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 7, 2012

    New changeset c9299edf1f67 by Ross Lagerwall in branch 'default':
    bpo-15277: Fix a resource leak in support.py when IPv6 is disabled.
    http://hg.python.org/cpython/rev/c9299edf1f67

    @rosslagerwall
    Copy link
    Mannequin

    rosslagerwall mannequin commented Jul 7, 2012

    Thanks.

    test_socket seems to be broken in all branches when running with net.ipv6.conf.all.disable_ipv6 = 1 but I'll open a new issue for that.

    @rosslagerwall rosslagerwall mannequin closed this as completed Jul 7, 2012
    @rosslagerwall rosslagerwall mannequin self-assigned this Jul 7, 2012
    @rosslagerwall
    Copy link
    Mannequin

    rosslagerwall mannequin commented Jul 7, 2012

    Ah, I see you've already opened a new issue for that (bpo-15284).

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    performance Performance or resource usage tests Tests in the Lib/test dir
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants