Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leaks in selectmodule.c #59600

Closed
jll mannequin opened this issue Jul 19, 2012 · 2 comments
Closed

memory leaks in selectmodule.c #59600

jll mannequin opened this issue Jul 19, 2012 · 2 comments
Labels
performance Performance or resource usage

Comments

@jll
Copy link
Mannequin

jll mannequin commented Jul 19, 2012

BPO 15395
Nosy @jcea
Files
  • selectmodule.patch: patch for selectmodule.c
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2012-07-19.19:33:20.102>
    created_at = <Date 2012-07-19.14:08:34.511>
    labels = ['performance']
    title = 'memory leaks in selectmodule.c'
    updated_at = <Date 2012-07-19.19:33:20.088>
    user = 'https://bugs.python.org/jll'

    bugs.python.org fields:

    activity = <Date 2012-07-19.19:33:20.088>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2012-07-19.19:33:20.102>
    closer = 'python-dev'
    components = []
    creation = <Date 2012-07-19.14:08:34.511>
    creator = 'jll'
    dependencies = []
    files = ['26436']
    hgrepos = []
    issue_num = 15395
    keywords = ['patch']
    message_count = 2.0
    messages = ['165840', '165867']
    nosy_count = 3.0
    nosy_names = ['jcea', 'python-dev', 'jll']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'resource usage'
    url = 'https://bugs.python.org/issue15395'
    versions = ['Python 3.2', 'Python 3.3']

    @jll
    Copy link
    Mannequin Author

    jll mannequin commented Jul 19, 2012

    In Modules/selectmodule.c, in the function seq2set, fast_seq should be decrefd on failure of the initialization of o. This will make a useless call to DECREF on o, but XDECREF is already used, so it is safe in the NULL case.

    In the same file, in the function poll_modify, key should be decrefed on all execution paths that lead out of the function.

    @jll jll mannequin added the performance Performance or resource usage label Jul 19, 2012
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jul 19, 2012

    New changeset bc9b2956bb8b by Jesus Cea in branch '3.2':
    Closes bpo-15395: memory leaks in selectmodule.c
    http://hg.python.org/cpython/rev/bc9b2956bb8b

    New changeset 9985b4651436 by Jesus Cea in branch 'default':
    MERGE: Closes bpo-15395: memory leaks in selectmodule.c
    http://hg.python.org/cpython/rev/9985b4651436

    @python-dev python-dev mannequin closed this as completed Jul 19, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    performance Performance or resource usage
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants