Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the list of default dirs filecmp.dircmp ignores #59647

Closed
elibendersky mannequin opened this issue Jul 24, 2012 · 14 comments
Closed

Expand the list of default dirs filecmp.dircmp ignores #59647

elibendersky mannequin opened this issue Jul 24, 2012 · 14 comments
Labels
easy stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@elibendersky
Copy link
Mannequin

elibendersky mannequin commented Jul 24, 2012

BPO 15442
Nosy @ezio-melotti, @merwok, @bitdancer, @cjerdonek
Files
  • 15442.patch: I've made the changes toDoc/library/filecmp.rst, Lib/filecmp.py. This is my first patch to python.I don't know how to compile python without having to install it but I'd sure like if someone showed me how to. I'd like to finish this and learn.
  • eli_issue15442.1.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2013-01-12.14:13:56.225>
    created_at = <Date 2012-07-24.16:32:11.641>
    labels = ['easy', 'type-feature', 'library']
    title = 'Expand the list of default dirs filecmp.dircmp ignores'
    updated_at = <Date 2014-03-10.22:11:22.868>
    user = 'https://bugs.python.org/elibendersky'

    bugs.python.org fields:

    activity = <Date 2014-03-10.22:11:22.868>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2013-01-12.14:13:56.225>
    closer = 'python-dev'
    components = ['Library (Lib)']
    creation = <Date 2012-07-24.16:32:11.641>
    creator = 'eli.bendersky'
    dependencies = []
    files = ['26971', '28669']
    hgrepos = []
    issue_num = 15442
    keywords = ['patch', 'easy']
    message_count = 14.0
    messages = ['166306', '168962', '169024', '172882', '172920', '172964', '172986', '172992', '179338', '179554', '179796', '179825', '179834', '213098']
    nosy_count = 7.0
    nosy_names = ['ezio.melotti', 'eric.araujo', 'r.david.murray', 'eli.bendersky', 'chris.jerdonek', 'python-dev', 'moijes12']
    pr_nums = []
    priority = 'low'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue15442'
    versions = ['Python 3.4']

    @elibendersky
    Copy link
    Mannequin Author

    elibendersky mannequin commented Jul 24, 2012

    The default ignore list of filecmp.dircmp is ['RCS', 'CVS', 'tags'].

    This predates even Subversion! I suggest to freshen up this module to also ignore the dirs for SVN, Mercurial, Git and Bazaar.

    [this is a new feature, so no earlier than 3.4...]

    @elibendersky elibendersky mannequin added stdlib Python modules in the Lib dir easy type-feature A feature request or enhancement labels Jul 24, 2012
    @cjerdonek
    Copy link
    Member

    Hi moijes12, for instructions on compiling and submitting patches, etc., see the Python Developer's Guide (aka the devguide). You may also be interested in the Python Mentors Group: http://pythonmentors.com/

    Lastly (a small point), in the future you can also type comments about your patch in the "Comment" text field in addition to the "File Description" text field. You can do this in the same "Submit Changes" operation that you use to choose and upload your file.

    @bitdancer
    Copy link
    Member

    moijes12, thanks for the patch. Since this is a new feature we'll need to wait until the 3.3 RC1 repo is branched before applying it.

    @elibendersky
    Copy link
    Mannequin Author

    elibendersky mannequin commented Oct 14, 2012

    moijes12, why are the added names "raw" ?

    @merwok
    Copy link
    Member

    merwok commented Oct 14, 2012

    ISTM the names should be regular names, not regular expression patterns.

    @elibendersky
    Copy link
    Mannequin Author

    elibendersky mannequin commented Oct 15, 2012

    I tend to agree with Éric here.

    moijes12, would you like to send an updated patch without the raw literals, and with added tests for the new/changed functionality?

    @moijes12
    Copy link
    Mannequin

    moijes12 mannequin commented Oct 15, 2012

    Yeah. I'm on it.

    @serhiy-storchaka
    Copy link
    Member

    Should __pycache__ be ignored too?

    @merwok
    Copy link
    Member

    merwok commented Jan 8, 2013

    Should __pycache__ be ignored too?
    Sounds good.

    I don't know how to compile python without having to install it
    See the devguide http://docs.python.org/devguide

    @elibendersky
    Copy link
    Mannequin Author

    elibendersky mannequin commented Jan 10, 2013

    Attaching an alternative patch, that goes one (little) step further. Instead of repeating the ignored list all over the place (code, docstrings, ReST docs), the module exposes DEFAULT_IGNORES so everything can refer to it.

    Also added some tests for this feature.

    The patch is only vs. default (3.4), of course.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jan 12, 2013

    New changeset a1efab48d8f8 by Eli Bendersky in branch 'default':
    Close bpo-15442: Expand the list of default directories ignored by filecmp.dircmp and expose it as a module attribute
    http://hg.python.org/cpython/rev/a1efab48d8f8

    @python-dev python-dev mannequin closed this as completed Jan 12, 2013
    @merwok
    Copy link
    Member

    merwok commented Jan 12, 2013

    + .. versionadded:: 3.3

    3.4*

    @elibendersky
    Copy link
    Mannequin Author

    elibendersky mannequin commented Jan 12, 2013

    What? Where did you see 3.3? It says 3.4 ;-)

    Thanks, fixed in 72ddb250f058

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 10, 2014

    New changeset 2b1d5caf63ca by R David Murray in branch 'default':
    whatsnew: filecmp.DEFAULT_IGNORES (bpo-15442)
    http://hg.python.org/cpython/rev/2b1d5caf63ca

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    easy stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants