Expand the list of default dirs filecmp.dircmp ignores

[elibendersky]

BPO	15442
Nosy	@ezio-melotti, @merwok, @bitdancer, @cjerdonek
Files	15442.patch: I've made the changes toDoc/library/filecmp.rst, Lib/filecmp.py. This is my first patch to python.I don't know how to compile python without having to install it but I'd sure like if someone showed me how to. I'd like to finish this and learn. eli_issue15442.1.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-01-12.14:13:56.225>
created_at = <Date 2012-07-24.16:32:11.641>
labels = ['easy', 'type-feature', 'library']
title = 'Expand the list of default dirs filecmp.dircmp ignores'
updated_at = <Date 2014-03-10.22:11:22.868>
user = 'https://bugs.python.org/elibendersky'

bugs.python.org fields:

activity = <Date 2014-03-10.22:11:22.868>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2013-01-12.14:13:56.225>
closer = 'python-dev'
components = ['Library (Lib)']
creation = <Date 2012-07-24.16:32:11.641>
creator = 'eli.bendersky'
dependencies = []
files = ['26971', '28669']
hgrepos = []
issue_num = 15442
keywords = ['patch', 'easy']
message_count = 14.0
messages = ['166306', '168962', '169024', '172882', '172920', '172964', '172986', '172992', '179338', '179554', '179796', '179825', '179834', '213098']
nosy_count = 7.0
nosy_names = ['ezio.melotti', 'eric.araujo', 'r.david.murray', 'eli.bendersky', 'chris.jerdonek', 'python-dev', 'moijes12']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue15442'
versions = ['Python 3.4']

[elibendersky]

The default ignore list of filecmp.dircmp is ['RCS', 'CVS', 'tags'].

This predates even Subversion! I suggest to freshen up this module to also ignore the dirs for SVN, Mercurial, Git and Bazaar.

[this is a new feature, so no earlier than 3.4...]

[cjerdonek]

Hi moijes12, for instructions on compiling and submitting patches, etc., see the Python Developer's Guide (aka the devguide). You may also be interested in the Python Mentors Group: http://pythonmentors.com/

Lastly (a small point), in the future you can also type comments about your patch in the "Comment" text field in addition to the "File Description" text field. You can do this in the same "Submit Changes" operation that you use to choose and upload your file.

[bitdancer]

moijes12, thanks for the patch. Since this is a new feature we'll need to wait until the 3.3 RC1 repo is branched before applying it.

[elibendersky]

moijes12, why are the added names "raw" ?

[merwok]

ISTM the names should be regular names, not regular expression patterns.

[elibendersky]

I tend to agree with Éric here.

moijes12, would you like to send an updated patch without the raw literals, and with added tests for the new/changed functionality?

[moijes12]

Yeah. I'm on it.

[serhiy-storchaka]

Should __pycache__ be ignored too?

[merwok]

Should __pycache__ be ignored too?
Sounds good.

I don't know how to compile python without having to install it
See the devguide http://docs.python.org/devguide

[elibendersky]

Attaching an alternative patch, that goes one (little) step further. Instead of repeating the ignored list all over the place (code, docstrings, ReST docs), the module exposes DEFAULT_IGNORES so everything can refer to it.

Also added some tests for this feature.

The patch is only vs. default (3.4), of course.

[python-dev]

New changeset a1efab48d8f8 by Eli Bendersky in branch 'default':
Close bpo-15442: Expand the list of default directories ignored by filecmp.dircmp and expose it as a module attribute
http://hg.python.org/cpython/rev/a1efab48d8f8

[merwok]

+ .. versionadded:: 3.3

3.4*

[elibendersky]

What? Where did you see 3.3? It says 3.4 ;-)

Thanks, fixed in 72ddb250f058

[python-dev]

New changeset 2b1d5caf63ca by R David Murray in branch 'default':
whatsnew: filecmp.DEFAULT_IGNORES (bpo-15442)
http://hg.python.org/cpython/rev/2b1d5caf63ca