Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 384 Refactoring applied to bz2 module #59859

Closed
RobinSchreiber mannequin opened this issue Aug 14, 2012 · 3 comments
Closed

PEP 384 Refactoring applied to bz2 module #59859

RobinSchreiber mannequin opened this issue Aug 14, 2012 · 3 comments
Labels
3.10 only security fixes extension-modules C modules in the Modules dir performance Performance or resource usage

Comments

@RobinSchreiber
Copy link
Mannequin

RobinSchreiber mannequin commented Aug 14, 2012

BPO 15654
Nosy @pitrou, @vstinner, @asvetlov, @corona10, @shihai1991
Files
  • _bz2_pep384_v0.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-06-22.09:18:50.639>
    created_at = <Date 2012-08-14.18:47:38.296>
    labels = ['extension-modules', '3.10', 'performance']
    title = 'PEP 384 Refactoring applied to bz2 module'
    updated_at = <Date 2020-06-22.09:18:50.635>
    user = 'https://bugs.python.org/RobinSchreiber'

    bugs.python.org fields:

    activity = <Date 2020-06-22.09:18:50.635>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2020-06-22.09:18:50.639>
    closer = 'vstinner'
    components = ['Extension Modules']
    creation = <Date 2012-08-14.18:47:38.296>
    creator = 'Robin.Schreiber'
    dependencies = []
    files = ['26808']
    hgrepos = []
    issue_num = 15654
    keywords = ['pep3121']
    message_count = 3.0
    messages = ['168221', '168230', '372059']
    nosy_count = 7.0
    nosy_names = ['pitrou', 'vstinner', 'nadeem.vawda', 'asvetlov', 'Robin.Schreiber', 'corona10', 'shihai1991']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'resource usage'
    url = 'https://bugs.python.org/issue15654'
    versions = ['Python 3.10']

    @RobinSchreiber
    Copy link
    Mannequin Author

    RobinSchreiber mannequin commented Aug 14, 2012

    Changes proposed in PEP-384 have now been applied to the bz2 module!

    @RobinSchreiber RobinSchreiber mannequin added extension-modules C modules in the Modules dir performance Performance or resource usage labels Aug 14, 2012
    @pitrou
    Copy link
    Member

    pitrou commented Aug 14, 2012

    Same review comments as in bpo-15653.

    @vstinner
    Copy link
    Member

    Issue fixed by these two changes.

    commit 5d38517
    Author: Hai Shi <shihai1992@gmail.com>
    Date: Tue Feb 18 19:17:39 2020 +0800

    bpo-1635741: Port _bz2 extension module to multiphase initialization(PEP-489) (GH-18050)
    

    commit ec68918
    Author: Dong-hee Na <donghee.na92@gmail.com>
    Date: Sat Jun 20 00:56:13 2020 +0900

    bpo-40077: Convert _bz2 module to use PyType_FromSpec (GH-20960)
    

    @vstinner vstinner added the 3.10 only security fixes label Jun 22, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 only security fixes extension-modules C modules in the Modules dir performance Performance or resource usage
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants