Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8 space indent in tutorial #60498

Closed
fossilet mannequin opened this issue Oct 21, 2012 · 4 comments
Closed

8 space indent in tutorial #60498

fossilet mannequin opened this issue Oct 21, 2012 · 4 comments
Assignees
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@fossilet
Copy link
Mannequin

fossilet mannequin commented Oct 21, 2012

BPO 16294
Nosy @jcea
Files
  • issue16294.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/jcea'
    closed_at = <Date 2012-10-22.11:16:26.906>
    created_at = <Date 2012-10-21.12:13:01.110>
    labels = ['type-feature', 'docs']
    title = '8 space indent in tutorial'
    updated_at = <Date 2012-10-22.11:16:26.904>
    user = 'https://bugs.python.org/fossilet'

    bugs.python.org fields:

    activity = <Date 2012-10-22.11:16:26.904>
    actor = 'python-dev'
    assignee = 'jcea'
    closed = True
    closed_date = <Date 2012-10-22.11:16:26.906>
    closer = 'python-dev'
    components = ['Documentation']
    creation = <Date 2012-10-21.12:13:01.110>
    creator = 'fossilet'
    dependencies = []
    files = ['27656']
    hgrepos = []
    issue_num = 16294
    keywords = ['patch']
    message_count = 4.0
    messages = ['173443', '173476', '173502', '173503']
    nosy_count = 5.0
    nosy_names = ['jcea', 'fossilet', 'docs@python', 'python-dev', 'mikehoy']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue16294'
    versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4']

    @fossilet
    Copy link
    Mannequin Author

    fossilet mannequin commented Oct 21, 2012

    http://docs.python.org/py3k/tutorial/stdlib2.html#weak-references

    In the code example, the two class funtions' bodies have indents of 8 spaces. All other indents in the docs are 4 spaces. I suggest here we use 4 spaces also.

    @fossilet fossilet mannequin assigned docspython Oct 21, 2012
    @fossilet fossilet mannequin added docs Documentation in the Doc dir type-feature A feature request or enhancement labels Oct 21, 2012
    @mikehoy
    Copy link
    Mannequin

    mikehoy mannequin commented Oct 21, 2012

    Probably no need for a patch (since it's such a simple fix) but I felt like doing something.

    @jcea
    Copy link
    Member

    jcea commented Oct 22, 2012

    I take care of this. Thanks for pointing it out.

    @jcea jcea assigned jcea and unassigned docspython Oct 22, 2012
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Oct 22, 2012

    New changeset 1a3f48c6ef16 by Jesus Cea in branch '2.7':
    Closes bpo-16294: 8 space indent in tutorial
    http://hg.python.org/cpython/rev/1a3f48c6ef16

    New changeset 2015db05d954 by Jesus Cea in branch '3.2':
    Closes bpo-16294: 8 space indent in tutorial
    http://hg.python.org/cpython/rev/2015db05d954

    New changeset 3344c8208662 by Jesus Cea in branch '3.3':
    MERGE: Closes bpo-16294: 8 space indent in tutorial
    http://hg.python.org/cpython/rev/3344c8208662

    New changeset 4ca40082461c by Jesus Cea in branch 'default':
    MERGE: Closes bpo-16294: 8 space indent in tutorial
    http://hg.python.org/cpython/rev/4ca40082461c

    @python-dev python-dev mannequin closed this as completed Oct 22, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant