Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link directly to set and frozenset in built-in function docs #60640

Closed
fossilet mannequin opened this issue Nov 8, 2012 · 7 comments
Closed

Link directly to set and frozenset in built-in function docs #60640

fossilet mannequin opened this issue Nov 8, 2012 · 7 comments
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@fossilet
Copy link
Mannequin

fossilet mannequin commented Nov 8, 2012

BPO 16436
Nosy @jcea, @ezio-melotti, @asvetlov, @cjerdonek

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-11-10.03:14:35.646>
created_at = <Date 2012-11-08.13:59:17.572>
labels = ['type-feature', 'docs']
title = 'Link directly to set and frozenset in built-in function docs'
updated_at = <Date 2012-11-10.03:14:35.644>
user = 'https://bugs.python.org/fossilet'

bugs.python.org fields:

activity = <Date 2012-11-10.03:14:35.644>
actor = 'chris.jerdonek'
assignee = 'docs@python'
closed = True
closed_date = <Date 2012-11-10.03:14:35.646>
closer = 'chris.jerdonek'
components = ['Documentation']
creation = <Date 2012-11-08.13:59:17.572>
creator = 'fossilet'
dependencies = []
files = []
hgrepos = []
issue_num = 16436
keywords = []
message_count = 7.0
messages = ['175157', '175159', '175189', '175191', '175259', '175260', '175261']
nosy_count = 7.0
nosy_names = ['jcea', 'fossilet', 'ezio.melotti', 'asvetlov', 'chris.jerdonek', 'docs@python', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue16436'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4']

@fossilet
Copy link
Mannequin Author

fossilet mannequin commented Nov 8, 2012

http://docs.python.org/3/library/functions.html#func-frozenset

http://docs.python.org/3/library/functions.html#func-set

frozenset and set function have no links to their definitions. Also the anchor name is prefixed with func, which is different to other builtin functions.

@fossilet fossilet mannequin assigned docspython Nov 8, 2012
@fossilet fossilet mannequin added the docs Documentation in the Doc dir label Nov 8, 2012
@asvetlov
Copy link
Contributor

asvetlov commented Nov 8, 2012

I guess the reason is that names are classes, not functions. See http://docs.python.org/3/library/functions.html#func-dict also for example.

@cjerdonek
Copy link
Member

Currently, the built-in types are not treated consistently as to whether their constructors are documented in the "Built-in Functions" or "Built-in Types" page. There are some open issues related to this topic (see, for example, bpo-16209).

For the purposes of this issue though, yes, I agree that the abbreviated built-in function versions of the documentation for set and frozenset should contain direct links to the more complete constructor documentation in the "Built-in Types" page (as is already done for dict, for example, as Andrew pointed out).

@cjerdonek cjerdonek changed the title Missing anchor in doc Link directly to set and frozenset in built-in function docs Nov 8, 2012
@cjerdonek cjerdonek added the type-feature A feature request or enhancement label Nov 8, 2012
@cjerdonek
Copy link
Member

I recommend copying for set and frozenset the documentation pattern for dict (and in particular by stating explicitly in its own sentence that the object is a class):

http://docs.python.org/3/library/functions.html#func-dict

@python-dev
Copy link
Mannequin

python-dev mannequin commented Nov 10, 2012

New changeset 16fa6462dfe1 by Chris Jerdonek in branch '3.2':
Link set and frozenset function docs to their class definitions (issue bpo-16436).
http://hg.python.org/cpython/rev/16fa6462dfe1

New changeset d534da27ca8b by Chris Jerdonek in branch '3.3':
Merge from 3.2: adjust set and frozenset function docs (issue bpo-16436).
http://hg.python.org/cpython/rev/d534da27ca8b

New changeset 1fde0d70f2b8 by Chris Jerdonek in branch 'default':
Merge from 3.3: adjust set and frozenset function docs (issue bpo-16436).
http://hg.python.org/cpython/rev/1fde0d70f2b8

@python-dev
Copy link
Mannequin

python-dev mannequin commented Nov 10, 2012

New changeset 24db5292c2c9 by Chris Jerdonek in branch '2.7':
Backport from 3.2: adjust set and frozenset function docs (issue bpo-16436).
http://hg.python.org/cpython/rev/24db5292c2c9

@cjerdonek
Copy link
Member

Fixed. Thanks a lot for the report, Yongzhi.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants