Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have BSD 'make -s' DTRT #60797

Closed
danielsh mannequin opened this issue Dec 2, 2012 · 3 comments
Closed

Have BSD 'make -s' DTRT #60797

danielsh mannequin opened this issue Dec 2, 2012 · 3 comments
Labels
build The build process and cross-build type-feature A feature request or enhancement

Comments

@danielsh
Copy link
Mannequin

danielsh mannequin commented Dec 2, 2012

BPO 16593
Nosy @tiran
Files
  • makedashs.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2012-12-02.06:39:38.774>
    created_at = <Date 2012-12-02.06:11:18.392>
    labels = ['type-feature', 'build']
    title = "Have BSD 'make -s' DTRT"
    updated_at = <Date 2012-12-02.07:26:16.352>
    user = 'https://bugs.python.org/danielsh'

    bugs.python.org fields:

    activity = <Date 2012-12-02.07:26:16.352>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2012-12-02.06:39:38.774>
    closer = 'christian.heimes'
    components = ['Build']
    creation = <Date 2012-12-02.06:11:18.392>
    creator = 'danielsh'
    dependencies = []
    files = ['28182']
    hgrepos = []
    issue_num = 16593
    keywords = ['patch']
    message_count = 3.0
    messages = ['176768', '176769', '176773']
    nosy_count = 3.0
    nosy_names = ['christian.heimes', 'python-dev', 'danielsh']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue16593'
    versions = ['Python 3.4']

    @danielsh
    Copy link
    Mannequin Author

    danielsh mannequin commented Dec 2, 2012

    FreeBSD make sets $$MAKEFLAGS differently than GNU make does. Attached patch updates Makefile.pre.in to recognise that syntax too.

    Preliminary versions discussed with Crys on #python-dev.

    @danielsh danielsh mannequin added build The build process and cross-build type-feature A feature request or enhancement labels Dec 2, 2012
    @tiran
    Copy link
    Member

    tiran commented Dec 2, 2012

    Thanks for your patch!

    Crys

    @tiran tiran closed this as completed Dec 2, 2012
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Dec 2, 2012

    New changeset ceb325fdd54e by Christian Heimes in branch '3.2':

    New changeset 323f0aeba89d by Christian Heimes in branch '3.3':
    Issue bpo-16593: Have BSD 'make -s' do the right thing, thanks to Daniel Shahaf
    http://hg.python.org/cpython/rev/323f0aeba89d

    New changeset 0fa67e3f195d by Christian Heimes in branch '2.7':

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant