Wrong test_extract_hardlink() in test_tarfile.py

[serhiy-storchaka]

BPO	16645
Nosy	@jcea, @pitrou, @ezio-melotti, @voidspace, @serhiy-storchaka
Files	test_tarfile_test_extract_hardlink.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2012-12-30.18:24:08.578>
created_at = <Date 2012-12-08.18:02:08.539>
labels = ['type-bug', 'tests']
title = 'Wrong test_extract_hardlink() in test_tarfile.py'
updated_at = <Date 2012-12-30.18:24:08.577>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2012-12-30.18:24:08.577>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2012-12-30.18:24:08.578>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2012-12-08.18:02:08.539>
creator = 'serhiy.storchaka'
dependencies = []
files = ['28275']
hgrepos = []
issue_num = 16645
keywords = ['patch']
message_count = 3.0
messages = ['177166', '178592', '178595']
nosy_count = 6.0
nosy_names = ['jcea', 'pitrou', 'ezio.melotti', 'michael.foord', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue16645'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4']

[serhiy-storchaka]

Test test_extract_hardlink() in Lib/test/test_tarfile.py ran 4 times. First time (uncompressed tarfile) it extract symbolic and hard links successfully, but in other 3 times (gzipped, bzipped and lzma'ed tarfile) extracting fails becouse this links already exists (left from first test). The test just ignore this error and other possible errors (error EEXIST raised, but ignored all except ENOENT).

Here is a patch, which adds a right cleanup of extracted links.

[ezio-melotti]

LGTM.

[python-dev]

New changeset 503b889668fc by Serhiy Storchaka in branch '2.7':
Issue bpo-16645: Fix hardlink extracting test for tarfile.
http://hg.python.org/cpython/rev/503b889668fc

New changeset d42bf4faf3d1 by Serhiy Storchaka in branch '3.2':
Issue bpo-16645: Fix hardlink extracting test for tarfile.
http://hg.python.org/cpython/rev/d42bf4faf3d1

New changeset e1a0901e4ef7 by Serhiy Storchaka in branch '3.3':
Issue bpo-16645: Fix hardlink extracting test for tarfile.
http://hg.python.org/cpython/rev/e1a0901e4ef7

New changeset f173c2e92b64 by Serhiy Storchaka in branch 'default':
Issue bpo-16645: Fix hardlink extracting test for tarfile.
http://hg.python.org/cpython/rev/f173c2e92b64