Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in test #61028

Closed
scoder opened this issue Dec 31, 2012 · 3 comments
Closed

typo in test #61028

scoder opened this issue Dec 31, 2012 · 3 comments
Assignees
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@scoder
Copy link
Contributor

scoder commented Dec 31, 2012

BPO 16824
Nosy @scoder, @serhiy-storchaka

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2012-12-31.09:41:41.420>
created_at = <Date 2012-12-31.08:26:55.299>
labels = ['type-bug', 'tests']
title = 'typo in test'
updated_at = <Date 2012-12-31.09:41:41.419>
user = 'https://github.com/scoder'

bugs.python.org fields:

activity = <Date 2012-12-31.09:41:41.419>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2012-12-31.09:41:41.420>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2012-12-31.08:26:55.299>
creator = 'scoder'
dependencies = []
files = []
hgrepos = []
issue_num = 16824
keywords = []
message_count = 3.0
messages = ['178653', '178657', '178658']
nosy_count = 3.0
nosy_names = ['scoder', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue16824'
versions = ['Python 3.3', 'Python 3.4']

@scoder
Copy link
Contributor Author

scoder commented Dec 31, 2012

Line 522 in test file Lib/test/test_pep380.py says:

                trace.append("Should not have yielded:", y)

However, 'trace' is a list and list.append() only takes one parameter, so this should read:

                trace.append("Should not have yielded: %r" % y)

I noticed it because Cython's type analysis refuses to compile this. This line is just a failure guard and is never reached in the normal test execution, that's why it doesn't show in CPython's test runs.

@scoder scoder added build The build process and cross-build tests Tests in the Lib/test dir labels Dec 31, 2012
@serhiy-storchaka serhiy-storchaka self-assigned this Dec 31, 2012
@python-dev
Copy link
Mannequin

python-dev mannequin commented Dec 31, 2012

New changeset 9472928af085 by Serhiy Storchaka in branch '3.3':
Issue bpo-16824: Fix a failure guard in the never reached in the normal test execution code in test_pep380.
http://hg.python.org/cpython/rev/9472928af085

New changeset 66665ef7d9d6 by Serhiy Storchaka in branch 'default':
Issue bpo-16824: Fix a failure guard in the never reached in the normal test execution code in test_pep380.
http://hg.python.org/cpython/rev/66665ef7d9d6

@serhiy-storchaka
Copy link
Member

Fixed. Thank you, Stefan. I will be glad to see new bugs which you will found with Cython.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error and removed build The build process and cross-build labels Dec 31, 2012
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants