Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makesetup should support .S source files #61073

Open
bennoleslie mannequin opened this issue Jan 5, 2013 · 3 comments
Open

makesetup should support .S source files #61073

bennoleslie mannequin opened this issue Jan 5, 2013 · 3 comments
Labels
build The build process and cross-build

Comments

@bennoleslie
Copy link
Mannequin

bennoleslie mannequin commented Jan 5, 2013

BPO 16869
Nosy @orsenthil
Files
  • makesetup-asm.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2013-01-05.05:56:47.207>
    labels = ['build']
    title = 'makesetup should support .S source files'
    updated_at = <Date 2013-01-06.05:31:07.544>
    user = 'https://bugs.python.org/bennoleslie'

    bugs.python.org fields:

    activity = <Date 2013-01-06.05:31:07.544>
    actor = 'bennoleslie'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Build']
    creation = <Date 2013-01-05.05:56:47.207>
    creator = 'bennoleslie'
    dependencies = []
    files = ['28574']
    hgrepos = []
    issue_num = 16869
    keywords = ['patch']
    message_count = 3.0
    messages = ['179111', '179134', '179172']
    nosy_count = 2.0
    nosy_names = ['orsenthil', 'bennoleslie']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = None
    status = 'open'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue16869'
    versions = ['Python 3.4']

    @bennoleslie
    Copy link
    Mannequin Author

    bennoleslie mannequin commented Jan 5, 2013

    It is useful to be able to build .S files as built-in modules (in particular if you want ctypes as a built-in you need .S files)

    The patch enables .S files to be specified in Setup.dist files.

    @bennoleslie bennoleslie mannequin added the build The build process and cross-build label Jan 5, 2013
    @orsenthil
    Copy link
    Member

    Should not this be?

    *.S) obj=basename $src .S.o; cc='$(CC)';; #

    The filetype extension .S instead .cpp.

    And, I have less know-how on these, but for my understanding how would
    non-preprocessed asm files (.s) will be handled? And doc reference to
    how this change is help as well (unless some other core dev knowing
    BUILD takes up).

    On Fri, Jan 4, 2013 at 9:56 PM, Benno Leslie <report@bugs.python.org> wrote:

    New submission from Benno Leslie:

    It is useful to be able to build .S files as built-in modules (in
    particular if you want ctypes as a built-in you need .S files)

    The patch enables .S files to be specified in Setup.dist files.

    ----------
    components: Build
    files: makesetup-asm.diff
    keywords: patch
    messages: 179111
    nosy: bennoleslie
    priority: normal
    severity: normal
    status: open
    title: makesetup should support .S source files
    versions: Python 3.4
    Added file: http://bugs.python.org/file28574/makesetup-asm.diff


    Python tracker <report@bugs.python.org>
    <http://bugs.python.org/issue16869\>



    New-bugs-announce mailing list
    New-bugs-announce@python.org
    http://mail.python.org/mailman/listinfo/new-bugs-announce

    @bennoleslie
    Copy link
    Mannequin Author

    bennoleslie mannequin commented Jan 6, 2013

    Thanks for the comments Senthil. I'll improve the patch fixing the bug, adding support for .s and updating the docs.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant