test_kqueue failure on NetBSD/OpenBSD

[neologix]

BPO	16952
Nosy	@skrah
Superseder	bpo-6419: Broken test_kqueue.py on OpenBSD
Files	kqueue_flags.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-01-17.17:24:26.223>
created_at = <Date 2013-01-13.14:24:57.473>
labels = ['type-bug', 'tests']
title = 'test_kqueue failure on NetBSD/OpenBSD'
updated_at = <Date 2013-01-17.17:24:26.215>
user = 'https://bugs.python.org/neologix'

bugs.python.org fields:

activity = <Date 2013-01-17.17:24:26.215>
actor = 'neologix'
assignee = 'none'
closed = True
closed_date = <Date 2013-01-17.17:24:26.223>
closer = 'neologix'
components = ['Tests']
creation = <Date 2013-01-13.14:24:57.473>
creator = 'neologix'
dependencies = []
files = ['28716']
hgrepos = []
issue_num = 16952
keywords = ['patch', 'needs review']
message_count = 2.0
messages = ['179877', '180128']
nosy_count = 2.0
nosy_names = ['skrah', 'neologix']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '6419'
type = 'behavior'
url = 'https://bugs.python.org/issue16952'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4']

[neologix]

test_kqueue fails on both NetBSD and OpenBSD:
http://buildbot.python.org/all/builders/AMD64 NetBSD 5.1.2 [SB] 2.7/builds/206/steps/test/logs/stdio
http://buildbot.python.org/all/builders/x86 OpenBSD 5.1 [SB] 2.7/builds/153/steps/test/logs/stdio

"""
======================================================================
FAIL: test_queue_event (test.test_kqueue.TestKQueue)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/home/cpython/buildslave/2.7.snakebite-netbsd51-amd64-1/build/Lib/test/test_kqueue.py", line 129, in test_queue_event
    (server.fileno(), select.KQ_FILTER_WRITE, flags)])
AssertionError: Lists differ: [(10L, 1, 5L), (11L, 1, 5L)] != [(10, 1, 0), (11, 1, 0)]

First differing element 0:
(10L, 1, 5L)
(10, 1, 0)

• [(10L, 1, 5L), (11L, 1, 5L)]
  ? - ^^ - ^^

+ [(10, 1, 0), (11, 1, 0)]
? ^
"""

The test assumes that the input flags (EV_ADD, EV_ENABLE...) will be returned in the output events. It's apparently not the case on OpenBSD and NetBSD (and probably on OS-X neither, because this check is disabled on this platform), and I can't see anything in the kqueue man pages hinting to this behavior (only specific flags will be set on output, like EV_ERROR). Knowing which flag was specified is not really useful actually.

The patch attached just removes this check (we keep checking the file descriptors and filter, of course).

[skrah]

Could we merge this with bpo-6419?