test_sni in test_urllib2net could be enabled

[pitrou]

BPO	17107
Nosy	@pitrou
Files	https_sni_test.patch: test case as requested

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-02-05.20:26:28.596>
created_at = <Date 2013-02-02.22:15:52.156>
labels = ['type-feature', 'tests']
title = 'test_sni in test_urllib2net could be enabled'
updated_at = <Date 2013-02-05.20:26:28.594>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2013-02-05.20:26:28.594>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2013-02-05.20:26:28.596>
closer = 'pitrou'
components = ['Tests']
creation = <Date 2013-02-02.22:15:52.156>
creator = 'pitrou'
dependencies = []
files = ['28948']
hgrepos = []
issue_num = 17107
keywords = ['patch']
message_count = 5.0
messages = ['181222', '181300', '181375', '181477', '181478']
nosy_count = 3.0
nosy_names = ['pitrou', 'grooverdan', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17107'
versions = ['Python 3.4']

[pitrou]

Right now test_sni in test_urllib2net is skipped with the message "test disabled - test server needed". But the ssl module now has server-side SNI support, and therefore we could implement this test with a local server (and perhaps move it to test_urllib2_localnet).

[grooverdan]

ask and you shall receive :-)

[pitrou]

Thanks for the patch :)
Since the test doesn't access a remote host (the version before it was skipped used to), I think it could be moved to test_urllib2_localnet. Also, the transient_internet() shouldn't be necessary.

[python-dev]

New changeset f74a12e23aaa by Antoine Pitrou in branch 'default':
Issue bpo-17107: Test client-side SNI support in urllib.request thanks to the new server-side SNI support in the ssl module.
http://hg.python.org/cpython/rev/f74a12e23aaa

[pitrou]

Ok, I've tweaked the patch a bit and committed it. Thank you!