Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code example in C API docsshould be highlighted #61458

Closed
RamchandraApte mannequin opened this issue Feb 20, 2013 · 6 comments
Closed

code example in C API docsshould be highlighted #61458

RamchandraApte mannequin opened this issue Feb 20, 2013 · 6 comments
Assignees
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@RamchandraApte
Copy link
Mannequin

RamchandraApte mannequin commented Feb 20, 2013

BPO 17256
Nosy @ezio-melotti, @cjerdonek, @kushaldas
Files
  • issue17256.patch: patch to fix syntax highlighting
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ezio-melotti'
    closed_at = <Date 2013-02-22.05:55:04.248>
    created_at = <Date 2013-02-20.14:45:30.968>
    labels = ['type-feature', 'docs']
    title = 'code example in C API docsshould be highlighted'
    updated_at = <Date 2013-02-22.05:55:04.242>
    user = 'https://bugs.python.org/RamchandraApte'

    bugs.python.org fields:

    activity = <Date 2013-02-22.05:55:04.242>
    actor = 'ezio.melotti'
    assignee = 'ezio.melotti'
    closed = True
    closed_date = <Date 2013-02-22.05:55:04.248>
    closer = 'ezio.melotti'
    components = ['Documentation']
    creation = <Date 2013-02-20.14:45:30.968>
    creator = 'Ramchandra Apte'
    dependencies = []
    files = ['29154']
    hgrepos = []
    issue_num = 17256
    keywords = ['patch']
    message_count = 6.0
    messages = ['182515', '182516', '182544', '182631', '182637', '182639']
    nosy_count = 6.0
    nosy_names = ['ezio.melotti', 'chris.jerdonek', 'docs@python', 'python-dev', 'Ramchandra Apte', 'kushal.das']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue17256'
    versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4']

    @RamchandraApte
    Copy link
    Mannequin Author

    RamchandraApte mannequin commented Feb 20, 2013

    in http://docs.python.org/2/extending/embedding.html#linking-requirements
    the code example isn't highlighted

    @RamchandraApte RamchandraApte mannequin added the docs Documentation in the Doc dir label Feb 20, 2013
    @RamchandraApte
    Copy link
    Mannequin Author

    RamchandraApte mannequin commented Feb 20, 2013

    Also in the section above: http://docs.python.org/2/extending/embedding.html#extending-embedded-python , the two code examples should be highlighted.

    @RamchandraApte RamchandraApte mannequin changed the title code example should be highlighted code example in C API docsshould be highlighted Feb 20, 2013
    @cjerdonek
    Copy link
    Member

    Looks like it's because highlightlang:: c is at the top.

    @ezio-melotti ezio-melotti added the type-feature A feature request or enhancement label Feb 20, 2013
    @kushaldas
    Copy link
    Member

    Following patch solves the problem.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 22, 2013

    New changeset ad55dc7de7fc by Ezio Melotti in branch '2.7':
    bpo-17256: fix syntax highlight in embedding example. Patch by Kushal Das.
    http://hg.python.org/cpython/rev/ad55dc7de7fc

    New changeset b42e7aeb4235 by Ezio Melotti in branch '3.2':
    bpo-17256: fix syntax highlight in embedding example. Patch by Kushal Das.
    http://hg.python.org/cpython/rev/b42e7aeb4235

    New changeset 3405d828ce95 by Ezio Melotti in branch '3.3':
    bpo-17256: merge with 3.2.
    http://hg.python.org/cpython/rev/3405d828ce95

    New changeset fb50eb64e097 by Ezio Melotti in branch 'default':
    bpo-17256: merge with 3.3.
    http://hg.python.org/cpython/rev/fb50eb64e097

    @ezio-melotti
    Copy link
    Member

    Fixed, thanks for the patch!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants