Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tests for the os module. #61725

Closed
willweaver mannequin opened this issue Mar 22, 2013 · 2 comments
Closed

Additional tests for the os module. #61725

willweaver mannequin opened this issue Mar 22, 2013 · 2 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@willweaver
Copy link
Mannequin

willweaver mannequin commented Mar 22, 2013

BPO 17523
Files
  • mywork.patch: Patch to test_os.py
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2013-11-26.19:23:51.193>
    created_at = <Date 2013-03-22.17:40:46.383>
    labels = ['type-feature', 'tests']
    title = 'Additional tests for the os module.'
    updated_at = <Date 2013-11-26.19:23:51.191>
    user = 'https://bugs.python.org/willweaver'

    bugs.python.org fields:

    activity = <Date 2013-11-26.19:23:51.191>
    actor = 'willweaver'
    assignee = 'none'
    closed = True
    closed_date = <Date 2013-11-26.19:23:51.193>
    closer = 'willweaver'
    components = ['Tests']
    creation = <Date 2013-03-22.17:40:46.383>
    creator = 'willweaver'
    dependencies = []
    files = ['29549']
    hgrepos = []
    issue_num = 17523
    keywords = ['patch']
    message_count = 2.0
    messages = ['184992', '204515']
    nosy_count = 1.0
    nosy_names = ['willweaver']
    pr_nums = []
    priority = 'normal'
    resolution = 'wont fix'
    stage = None
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue17523'
    versions = ['Python 3.4']

    @willweaver
    Copy link
    Mannequin Author

    willweaver mannequin commented Mar 22, 2013

    I've reorganized and added some os module tests.

    I split the makedirs tests into additional test methods that test one thing instead of a lot of different things. I added additional test coverage for a trailing '/'.

    I've also added the same test for removedirs.

    I reorganized the walk tests so that they actually run. Before there was only a setUp and a tearDown but no actual tests so the tests would not actually run.

    Lastly, I added tests for renames as there weren't any before.

    @willweaver willweaver mannequin added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Mar 22, 2013
    @willweaver
    Copy link
    Mannequin Author

    willweaver mannequin commented Nov 26, 2013

    It seems that I probably missed some tests as I only ran then on Mac OS. Such a minor addition so no need to do anything about it. If I go about it in a better way I'll make a new issue.

    @willweaver willweaver mannequin closed this as completed Nov 26, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants