mingw: configure MACHDEP and platform for build

[rpetrov]

BPO	17592
Nosy	@vadmium
Files	0004-MINGW-configure-MACHDEP-and-platform-for-build.patch MINGW-MACHDEP.v2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-10-20.12:42:30.091>
created_at = <Date 2013-03-31.19:43:30.946>
labels = ['type-feature', 'build']
title = 'mingw: configure MACHDEP and platform for build'
updated_at = <Date 2021-10-20.12:42:30.090>
user = 'https://bugs.python.org/rpetrov'

bugs.python.org fields:

activity = <Date 2021-10-20.12:42:30.090>
actor = 'iritkatriel'
assignee = 'none'
closed = True
closed_date = <Date 2021-10-20.12:42:30.091>
closer = 'iritkatriel'
components = ['Build', 'Cross-Build']
creation = <Date 2013-03-31.19:43:30.946>
creator = 'rpetrov'
dependencies = []
files = ['29626', '42142']
hgrepos = []
issue_num = 17592
keywords = ['patch']
message_count = 3.0
messages = ['185650', '261600', '261632']
nosy_count = 2.0
nosy_names = ['rpetrov', 'martin.panter']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17592'
versions = ['Python 3.4']

[rpetrov]

split of bpo-3871

[vadmium]

There are some spelling errors in the comments. It would also be good to keep the indentation, quoting, layout etc similar to the surrounding code.

Regarding the comments, what is the significance of “runtime platform” vs MACHDEP? Also, what is the significance of sys.platform() when setting _PYTHON_HOST_PLATFORM?

Why did you use different types of comments? (# vs dnl)

I do not understand the comment “build must not depend from posix-compatible environment”. Is this just explaining that we are setting ac_sys_system (uname -s) to a dummy generic value that will not trigger any special cases. Should we also set ac_sys_release to an empty string, like the cross-compiling case later on?

What’s the go with the two competing “mingw*)” cases when determining _PYTHON_HOST_PLATFORM? What is the situation where $host matches *--mingw, but $host_os does not match mingw*?

[vadmium]

Here is a modified patch fixing a couple of the spelling & style problems. I moved the comment introducing the ac_sys_ variables up to before the code that sets them. I rearranged the logic for _PYTHON_HOST_PLATFORM so it is clear that $host_os overrides $host, and I combined the cygwin and mingw cases.

I suspect the configure.ac logic could be simplified more.