Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDLE: Remove config option 'editor on startup' and utilize command line options only #61809

Closed
rovitotv mannequin opened this issue Apr 1, 2013 · 8 comments
Closed
Labels
topic-IDLE type-feature A feature request or enhancement

Comments

@rovitotv
Copy link
Mannequin

rovitotv mannequin commented Apr 1, 2013

BPO 17609
Nosy @terryjreedy, @ronaldoussoren, @taleinat, @serwy, @rovitotv

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-04-03.04:30:18.641>
created_at = <Date 2013-04-01.11:51:27.375>
labels = ['expert-IDLE', 'type-feature']
title = "IDLE: Remove config option 'editor on startup' and utilize command line options only"
updated_at = <Date 2013-04-03.04:30:18.640>
user = 'https://github.com/rovitotv'

bugs.python.org fields:

activity = <Date 2013-04-03.04:30:18.640>
actor = 'Todd.Rovito'
assignee = 'none'
closed = True
closed_date = <Date 2013-04-03.04:30:18.641>
closer = 'Todd.Rovito'
components = ['IDLE']
creation = <Date 2013-04-01.11:51:27.375>
creator = 'Todd.Rovito'
dependencies = []
files = []
hgrepos = []
issue_num = 17609
keywords = []
message_count = 8.0
messages = ['185731', '185733', '185737', '185753', '185768', '185880', '185882', '185886']
nosy_count = 7.0
nosy_names = ['terry.reedy', 'ronaldoussoren', 'taleinat', 'roger.serwy', 'Todd.Rovito', 'seanfelipewolfe', 'Guilherme.Sim\xc3\xb5es']
pr_nums = []
priority = 'normal'
resolution = 'rejected'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17609'
versions = ['Python 3.4']

@rovitotv
Copy link
Mannequin Author

rovitotv mannequin commented Apr 1, 2013

Based on enhancements from this issue:
http://bugs.python.org/issue6698

Comments from Tal Einat

The "editor-on-startup" config option should be removed. Running IDLE without arguments should open a shell. If IDLE is asked to open any files for editing, it should open just editor windows. IDLE should open both a shell window and one or more editor windows only when explicitly asked to do so on the command line.

If this is done, the -e option ("open an editor") would tell IDLE to open an empty editor window if no files are asked to be opened for editing. If no other arguments are given, IDLE will open just an editor window (no shell window). The -i option ("open a shell") would tell IDLE to open a shell window even if asked to open files for editing.

I think this is more obvious and easier to work with. It will also make the command line argument processing code simpler. And as a bonus we remove a config option :)

I will also post on idle-dev for discussion as Terry Reedy requested.

@rovitotv rovitotv mannequin added topic-IDLE type-feature A feature request or enhancement labels Apr 1, 2013
@ronaldoussoren
Copy link
Contributor

I agree with the change, but keep in mind that at least on OSX a lot of users start IDLE by double clicking on the IDLE application in the Finder (or double-clicking a .py file) and as such don't have an easy way to specify the -e or -i options.

@GuilhermeSimes
Copy link
Mannequin

GuilhermeSimes mannequin commented Apr 1, 2013

IDLE is widely used by students and should have its most relevant settings available in the GUI also.

@terryjreedy
Copy link
Member

I think whatever we do should be done on all versions. This is not a 'major rewrite'.

As I remember, installing Python on Windows adds 'edit with IDLE' to the right-click context menu. I cannot check at the moment because my substitute machine only has repository builds. I do not know what happens with multiple installs. Perhaps there should be 'Edit with Idle x.y' for each. 'Run with Idle' might be nice,

@terryjreedy
Copy link
Member

A corollary of what I said is that if something is a bad idea for 3.3, it is probably a bad idea for 3.4.

On idle-dev thread "Feedback requested on bpo-17609: ...", Bruce Sherwood says "For the thousands of students in our intro physics curriculum who use VIDLE (which I hope eventually can be replaced by using an updated IDLE), it is extremely important that starting IDLE (by clicking on an icon) display only an edit window at startup".

Idle is both a shell with editor and an editor with shell. The latter is a legitimate use case and I do not think we should remove the feature of making it a configuration option. So I think this issue should be closed as rejected (and see below).

On Windows, I believe one could accomplish Bruce's purpose with a customized Window's shortcut. Even is something similar is true on *nix and Mac, the details would probably be different on both. Learning all three systems is too much to expect of anyone.

I am sympathetic with the idea of making option processing easier (but not as the cost of making things harder for users). I believe using the newer argparse instead of the ancient getopt in PyShell.main might do that. It seems to me that the flow should be dict of builtin default updated by user configuration file updated by command line or function args. 'Function' refers to a possible new idlelib.idle.main for starting Idle from Python by passing options directly as arguments rather than by manipulating sys.argv.

I do not see 'remove a config option' as a goal.

@seanfelipewolfe
Copy link
Mannequin

seanfelipewolfe mannequin commented Apr 3, 2013

fwiw, I like the configuration option. I tend to set idle to editor only, but the configuration option is useful to me.

@rovitotv
Copy link
Mannequin Author

rovitotv mannequin commented Apr 3, 2013

Thanks for the feedback I am good with closing but want to check with Roger because he suggested that we open a new issue to discuss.

@serwy
Copy link
Mannequin

serwy mannequin commented Apr 3, 2013

Todd, thank you for opening this issue. Given the feedback, it looks like we should keep the configuration. Feel free to close the issue.

@rovitotv rovitotv mannequin closed this as completed Apr 3, 2013
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-IDLE type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants