test_urllib2 convert doctests to unittest

[orsenthil]

BPO	17648
Nosy	@orsenthil, @ezio-melotti, @merwok, @bitdancer
Files	remove_doctests.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/orsenthil'
closed_at = <Date 2013-04-09.13:03:30.862>
created_at = <Date 2013-04-06.23:45:14.821>
labels = ['type-bug']
title = 'test_urllib2 convert doctests to unittest'
updated_at = <Date 2013-04-09.13:03:45.004>
user = 'https://github.com/orsenthil'

bugs.python.org fields:

activity = <Date 2013-04-09.13:03:45.004>
actor = 'orsenthil'
assignee = 'orsenthil'
closed = True
closed_date = <Date 2013-04-09.13:03:30.862>
closer = 'orsenthil'
components = []
creation = <Date 2013-04-06.23:45:14.821>
creator = 'orsenthil'
dependencies = []
files = ['29700']
hgrepos = []
issue_num = 17648
keywords = ['patch']
message_count = 5.0
messages = ['186171', '186375', '186376', '186395', '186396']
nosy_count = 5.0
nosy_names = ['orsenthil', 'ezio.melotti', 'eric.araujo', 'r.david.murray', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue17648'
versions = ['Python 3.3', 'Python 3.4']

[orsenthil]

Sometime back during an IRC conversation we realized that converting test_urllib2 doctests to proper unittest may help in various ways.
a) Improve coverage report (?) Know what is covered and not.
b) Helps expand it further when new features are added.

Here is patch which removes the old doctests and converts them to unittest.

Reviews will be helpful.

[python-dev]

New changeset eb632aafff57 by Senthil Kumaran in branch 'default':
bpo-17648 - Clean up test_urllib2.py. Converted doctests to unittest for
http://hg.python.org/cpython/rev/eb632aafff57

[orsenthil]

I have pushed the changes since they are restricted to test files. If there are review comments, I shall do make the changes.

I shall consider to to make 3.3 tests close to default branch ones so that fixes can be backported. (Leaving the bug open for that).

[python-dev]

New changeset 5c9b36969abc by Senthil Kumaran in branch '3.3':
bpo-17648 - convert test_urllib2.py doctests to unittests
http://hg.python.org/cpython/rev/5c9b36969abc

[orsenthil]

Changed in active branches (3.3 and default).