Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert test_wsgiref to idiomatic unittest code #61865

Closed
tshepang mannequin opened this issue Apr 8, 2013 · 3 comments
Closed

convert test_wsgiref to idiomatic unittest code #61865

tshepang mannequin opened this issue Apr 8, 2013 · 3 comments
Assignees
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@tshepang
Copy link
Mannequin

tshepang mannequin commented Apr 8, 2013

BPO 17665
Nosy @terryjreedy, @orsenthil, @ezio-melotti, @berkerpeksag, @serhiy-storchaka
Superseder
  • bpo-20555: Use specific asserts in urllib related tests
  • Files
  • diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/orsenthil'
    closed_at = <Date 2014-08-05.05:01:38.672>
    created_at = <Date 2013-04-08.17:46:27.432>
    labels = ['type-feature', 'tests']
    title = 'convert test_wsgiref to idiomatic unittest code'
    updated_at = <Date 2014-08-05.05:01:38.671>
    user = 'https://bugs.python.org/tshepang'

    bugs.python.org fields:

    activity = <Date 2014-08-05.05:01:38.671>
    actor = 'ezio.melotti'
    assignee = 'orsenthil'
    closed = True
    closed_date = <Date 2014-08-05.05:01:38.672>
    closer = 'ezio.melotti'
    components = ['Tests']
    creation = <Date 2013-04-08.17:46:27.432>
    creator = 'tshepang'
    dependencies = []
    files = ['29780']
    hgrepos = []
    issue_num = 17665
    keywords = []
    message_count = 3.0
    messages = ['186701', '186741', '223524']
    nosy_count = 7.0
    nosy_names = ['terry.reedy', 'orsenthil', 'ezio.melotti', 'BreamoreBoy', 'tshepang', 'berker.peksag', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = 'out of date'
    stage = 'resolved'
    status = 'closed'
    superseder = '20555'
    type = 'enhancement'
    url = 'https://bugs.python.org/issue17665'
    versions = ['Python 3.4', 'Python 3.5']

    @tshepang tshepang mannequin added the tests Tests in the Lib/test dir label Apr 8, 2013
    @terryjreedy terryjreedy added the performance Performance or resource usage label Apr 12, 2013
    @terryjreedy terryjreedy changed the title convert to idiomatic unittest code convert test_wsgiref to idiomatic unittest code Apr 12, 2013
    @orsenthil orsenthil self-assigned this Apr 12, 2013
    @serhiy-storchaka
    Copy link
    Member

    I don't think the second change is correct.

    See also bpo-16510.

    @serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement and removed performance Performance or resource usage labels Apr 13, 2013
    @ezio-melotti
    Copy link
    Member

    In this case I don't think it matters much. The value is either True or False, so both assertTrue(...) and assertIs(..., True) work, even though the latter is technically more accurate.

    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Jul 20, 2014

    Changes were made to this module on bpo-20555.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants