Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test discovery for test_random.py #61989

Closed
zware opened this issue Apr 18, 2013 · 3 comments
Closed

Fix test discovery for test_random.py #61989

zware opened this issue Apr 18, 2013 · 3 comments
Assignees
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@zware
Copy link
Member

zware commented Apr 18, 2013

BPO 17789
Nosy @brettcannon, @ezio-melotti, @zware
Files
  • test_random_discovery.diff: test_random.py fix, version 1
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ezio-melotti'
    closed_at = <Date 2013-04-19.02:46:51.085>
    created_at = <Date 2013-04-18.15:03:51.115>
    labels = ['type-bug', 'tests']
    title = 'Fix test discovery for test_random.py'
    updated_at = <Date 2013-04-19.02:46:51.084>
    user = 'https://github.com/zware'

    bugs.python.org fields:

    activity = <Date 2013-04-19.02:46:51.084>
    actor = 'ezio.melotti'
    assignee = 'ezio.melotti'
    closed = True
    closed_date = <Date 2013-04-19.02:46:51.085>
    closer = 'ezio.melotti'
    components = ['Tests']
    creation = <Date 2013-04-18.15:03:51.115>
    creator = 'zach.ware'
    dependencies = []
    files = ['29922']
    hgrepos = []
    issue_num = 17789
    keywords = ['patch']
    message_count = 3.0
    messages = ['187257', '187334', '187335']
    nosy_count = 4.0
    nosy_names = ['brett.cannon', 'ezio.melotti', 'python-dev', 'zach.ware']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue17789'
    versions = ['Python 3.3', 'Python 3.4']

    @zware
    Copy link
    Member Author

    zware commented Apr 18, 2013

    This one had subclassing issues, and SystemRandom_TestBasicOps was being skipped by exclusion from the list of tests passed to support.run_unittest, so it's been converted to a skip decorator.

    @zware zware added tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Apr 18, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Apr 19, 2013

    New changeset 678564fc0962 by Ezio Melotti in branch '3.3':
    bpo-17789: test_random now works with unittest test discovery. Patch by Zachary Ware.
    http://hg.python.org/cpython/rev/678564fc0962

    New changeset ac352d7d8058 by Ezio Melotti in branch 'default':
    bpo-17789: merge with 3.3.
    http://hg.python.org/cpython/rev/ac352d7d8058

    @ezio-melotti
    Copy link
    Member

    Fixed, thanks for the patch!

    @ezio-melotti ezio-melotti self-assigned this Apr 19, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants