thread states should use a doubly-linked list

[pitrou]

BPO	17912
Nosy	@pitrou
Files	pystate.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-05-08.20:53:00.756>
created_at = <Date 2013-05-05.22:02:39.502>
labels = ['interpreter-core', 'type-feature']
title = 'thread states should use a doubly-linked list'
updated_at = <Date 2013-05-08.20:53:00.755>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2013-05-08.20:53:00.755>
actor = 'neologix'
assignee = 'none'
closed = True
closed_date = <Date 2013-05-08.20:53:00.756>
closer = 'neologix'
components = ['Interpreter Core']
creation = <Date 2013-05-05.22:02:39.502>
creator = 'pitrou'
dependencies = []
files = ['30168']
hgrepos = []
issue_num = 17912
keywords = ['patch', 'needs review']
message_count = 6.0
messages = ['188471', '188581', '188586', '188638', '188715', '188733']
nosy_count = 3.0
nosy_names = ['pitrou', 'neologix', 'python-dev']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17912'
versions = ['Python 3.4']

[pitrou]

Thread states are stored in a singly linked list, which makes some operations more cumbersome than they should be. Since memory consumption is far from critical here, it would be easier to handle them with a doubly linked list.

[neologix]

Are there other places in the code base using linked-list?
If yes, I think it could be interesting to add a generic linked-list
implementation, like the one used in the Linux kernel:
http://kernelnewbies.org/FAQ/LinkedLists
http://isis.poly.edu/kulesh/stuff/src/klist/

[pitrou]

Are there other places in the code base using linked-list?
If yes, I think it could be interesting to add a generic linked-list
implementation, like the one used in the Linux kernel:
http://kernelnewbies.org/FAQ/LinkedLists
http://isis.poly.edu/kulesh/stuff/src/klist/

There are a couple other places, IIRC. That said, I'm not sure what the
point is, since a linked list is quite a simple structure anyway?

[neologix]

There are a couple other places, IIRC. That said, I'm not sure what the
point is, since a linked list is quite a simple structure anyway?

Well, it was just to avoid code duplication, and gain a nice iteration macro ;-)

Anyway, I'll submit a patch later today.

[pitrou]

Your patch looks fine to me, thank you.

[python-dev]

New changeset 375d4fed4cf2 by Charles-Francois Natali in branch 'default':
Issue bpo-17912: Use a doubly linked-list for thread states.
http://hg.python.org/cpython/rev/375d4fed4cf2