Refactor call_with_frame() function of pyexpat.c

[vstinner]

BPO	18421
Nosy	@freddrake, @vstinner, @tiran

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-12-16.23:14:32.649>
created_at = <Date 2013-07-10.11:45:56.651>
labels = ['expert-XML']
title = 'Refactor call_with_frame() function of pyexpat.c'
updated_at = <Date 2013-12-16.23:14:32.648>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2013-12-16.23:14:32.648>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2013-12-16.23:14:32.649>
closer = 'vstinner'
components = ['XML']
creation = <Date 2013-07-10.11:45:56.651>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 18421
keywords = []
message_count = 2.0
messages = ['192796', '206389']
nosy_count = 3.0
nosy_names = ['fdrake', 'vstinner', 'christian.heimes']
pr_nums = []
priority = 'normal'
resolution = 'wont fix'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue18421'
versions = ['Python 3.4']

[vstinner]

Modules/pyexpat.c contains a call_with_frame() function which uses many low-level attributes like tstate->c_profilefunc. I don't think that pyexpat.c is the best place for such function, it should be moved to Python/ceval.c.

Except the call to XML_StopParser(self->itself, XML_FALSE); on failure, the code doesn't look to be specific to (py)expat.

[vstinner]

I'm not really interested to refactory pyexpat.c code. If you are interested, open a new the issue with a patch.