Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are unused variables inside DateTimeTestCase class in test_xmlrpc.py #62653

Closed
vajrasky mannequin opened this issue Jul 14, 2013 · 5 comments
Closed

There are unused variables inside DateTimeTestCase class in test_xmlrpc.py #62653

vajrasky mannequin opened this issue Jul 14, 2013 · 5 comments
Assignees
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@vajrasky
Copy link
Mannequin

vajrasky mannequin commented Jul 14, 2013

BPO 18453
Nosy @abalkin, @ezio-melotti, @vajrasky
Files
  • fix_DateTimeTestCase.txt: Fix for unit test inside DateTimeTestCase class in test_xmlrpc.py
  • fix_DateTimeTestCase_using_mock_object.txt: Fix for unit test inside DateTimeTestCase class in test_xmlrpc.py using mock object
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ezio-melotti'
    closed_at = <Date 2013-08-10.15:38:22.962>
    created_at = <Date 2013-07-14.15:58:59.205>
    labels = ['type-feature', 'tests']
    title = 'There are unused variables inside DateTimeTestCase class in test_xmlrpc.py'
    updated_at = <Date 2013-08-10.15:38:22.959>
    user = 'https://github.com/vajrasky'

    bugs.python.org fields:

    activity = <Date 2013-08-10.15:38:22.959>
    actor = 'ezio.melotti'
    assignee = 'ezio.melotti'
    closed = True
    closed_date = <Date 2013-08-10.15:38:22.962>
    closer = 'ezio.melotti'
    components = ['Tests']
    creation = <Date 2013-07-14.15:58:59.205>
    creator = 'vajrasky'
    dependencies = []
    files = ['30919', '30920']
    hgrepos = []
    issue_num = 18453
    keywords = []
    message_count = 5.0
    messages = ['193059', '193061', '193485', '194805', '194806']
    nosy_count = 4.0
    nosy_names = ['belopolsky', 'ezio.melotti', 'python-dev', 'vajrasky']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue18453'
    versions = ['Python 3.3', 'Python 3.4']

    @vajrasky
    Copy link
    Mannequin Author

    vajrasky mannequin commented Jul 14, 2013

    Attached the menial fix to unit test in test_xmlrpc.py.

    @vajrasky vajrasky mannequin added the tests Tests in the Lib/test dir label Jul 14, 2013
    @vajrasky
    Copy link
    Mannequin Author

    vajrasky mannequin commented Jul 14, 2013

    Okay, instead of using computer timer, I use mock object instead.

    @abalkin
    Copy link
    Member

    abalkin commented Jul 22, 2013

    LGTM

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Aug 10, 2013

    New changeset 28c756093a63 by Ezio Melotti in branch '3.3':
    bpo-18453: fix unused variables in test_xmlrpc. Patch by Vajrasky Kok.
    http://hg.python.org/cpython/rev/28c756093a63

    New changeset 9f7581816890 by Ezio Melotti in branch 'default':
    bpo-18453: merge with 3.3.
    http://hg.python.org/cpython/rev/9f7581816890

    @ezio-melotti
    Copy link
    Member

    Fixed, thanks for the report and the patch!

    @ezio-melotti ezio-melotti self-assigned this Aug 10, 2013
    @ezio-melotti ezio-melotti added the type-feature A feature request or enhancement label Aug 10, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants