Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References to non-existant "StringIO" module #62943

Closed
jcea opened this issue Aug 15, 2013 · 9 comments
Closed

References to non-existant "StringIO" module #62943

jcea opened this issue Aug 15, 2013 · 9 comments
Assignees
Labels
docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@jcea
Copy link
Member

jcea commented Aug 15, 2013

BPO 18743
Nosy @terryjreedy, @jcea, @serhiy-storchaka
Files
  • doc_StringIO_refs.patch
  • doc_StringIO_refs_2.patch
  • src_StringIO_refs.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2013-08-29.08:48:46.839>
    created_at = <Date 2013-08-15.05:01:51.704>
    labels = ['type-bug', 'docs']
    title = 'References to non-existant "StringIO" module'
    updated_at = <Date 2013-08-29.08:48:46.838>
    user = 'https://github.com/jcea'

    bugs.python.org fields:

    activity = <Date 2013-08-29.08:48:46.838>
    actor = 'serhiy.storchaka'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2013-08-29.08:48:46.839>
    closer = 'serhiy.storchaka'
    components = ['Documentation']
    creation = <Date 2013-08-15.05:01:51.704>
    creator = 'jcea'
    dependencies = []
    files = ['31315', '31321', '31362']
    hgrepos = []
    issue_num = 18743
    keywords = ['patch']
    message_count = 9.0
    messages = ['195231', '195340', '195346', '195385', '195386', '195411', '195420', '195573', '196446']
    nosy_count = 5.0
    nosy_names = ['terry.reedy', 'jcea', 'docs@python', 'python-dev', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue18743'
    versions = ['Python 3.3', 'Python 3.4']

    @jcea
    Copy link
    Member Author

    jcea commented Aug 15, 2013

    Doing a "grep StringIO Doc/library/*.rst" shows a handful of references to the old StringIO library. Notably:

    gzip.rst
    mailbox.rst
    tempfile.rst
    test.rst
    unittest.mock.rst
    xml.dom.minidom.rst

    @jcea jcea added the docs Documentation in the Doc dir label Aug 15, 2013
    @serhiy-storchaka
    Copy link
    Member

    Here is a patch. Actually this is a small part of larger problem for which I will open several separated issues.

    @jcea
    Copy link
    Member Author

    jcea commented Aug 16, 2013

    Patch is incomplete. I found this error while reading "unittest.mock", that you are not patching.

    @serhiy-storchaka
    Copy link
    Member

    I don't see StringIO in Doc/library/unittest.mock.rst.

    @serhiy-storchaka
    Copy link
    Member

    Ah, I missed it. Here is completed patch.

    @terryjreedy
    Copy link
    Member

    LGTM

    @terryjreedy terryjreedy added the type-bug An unexpected behavior, bug, or error label Aug 16, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Aug 16, 2013

    New changeset b23ad357c214 by Serhiy Storchaka in branch '3.3':
    Issue bpo-18743: Fix references to non-existant "StringIO" module.
    http://hg.python.org/cpython/rev/b23ad357c214

    New changeset 3acbd7aca856 by Serhiy Storchaka in branch 'default':
    Issue bpo-18743: Fix references to non-existant "StringIO" module.
    http://hg.python.org/cpython/rev/3acbd7aca856

    @serhiy-storchaka
    Copy link
    Member

    Here is a patch which fixes references to StringIO in docstrings and comments and removes redundant code.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Aug 29, 2013

    New changeset 6c0f5af2f5a5 by Serhiy Storchaka in branch '3.3':
    Issue bpo-18743: Fix references to non-existant "StringIO" module
    http://hg.python.org/cpython/rev/6c0f5af2f5a5

    New changeset 676bbd5b0254 by Serhiy Storchaka in branch 'default':
    Issue bpo-18743: Fix references to non-existant "StringIO" module
    http://hg.python.org/cpython/rev/676bbd5b0254

    New changeset 8c768bbacd92 by Serhiy Storchaka in branch '2.7':
    Issue bpo-18743: Improved cross-references to the StringIO class.
    http://hg.python.org/cpython/rev/8c768bbacd92

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants