Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo and unused variables in test fcntl #62998

Closed
vajrasky mannequin opened this issue Aug 21, 2013 · 3 comments
Closed

Typo and unused variables in test fcntl #62998

vajrasky mannequin opened this issue Aug 21, 2013 · 3 comments
Assignees
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@vajrasky
Copy link
Mannequin

vajrasky mannequin commented Aug 21, 2013

BPO 18798
Nosy @ezio-melotti, @vajrasky
Files
  • fix_typo_unused_variables_in_test_fcntl.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ezio-melotti'
    closed_at = <Date 2013-08-23.20:10:23.430>
    created_at = <Date 2013-08-21.10:29:20.507>
    labels = ['type-feature', 'tests']
    title = 'Typo and unused variables in test fcntl'
    updated_at = <Date 2013-08-23.20:10:23.428>
    user = 'https://github.com/vajrasky'

    bugs.python.org fields:

    activity = <Date 2013-08-23.20:10:23.428>
    actor = 'ezio.melotti'
    assignee = 'ezio.melotti'
    closed = True
    closed_date = <Date 2013-08-23.20:10:23.430>
    closer = 'ezio.melotti'
    components = ['Tests']
    creation = <Date 2013-08-21.10:29:20.507>
    creator = 'vajrasky'
    dependencies = []
    files = ['31398']
    hgrepos = []
    issue_num = 18798
    keywords = ['patch']
    message_count = 3.0
    messages = ['195768', '196019', '196020']
    nosy_count = 3.0
    nosy_names = ['ezio.melotti', 'python-dev', 'vajrasky']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue18798'
    versions = ['Python 2.7', 'Python 3.3', 'Python 3.4']

    @vajrasky
    Copy link
    Mannequin Author

    vajrasky mannequin commented Aug 21, 2013

    Typo in line 11:
    # Skip test if no fnctl module.

    Unused variables rv in test_fcntl_file_descriptor method.

    Attached the patch to clean up the test.

    @vajrasky vajrasky mannequin added the tests Tests in the Lib/test dir label Aug 21, 2013
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Aug 23, 2013

    New changeset d7bac470951b by Ezio Melotti in branch '2.7':
    bpo-18798: fix typo in test_fcntl. Patch by Vajrasky Kok.
    http://hg.python.org/cpython/rev/d7bac470951b

    New changeset 41c90b8f49d9 by Ezio Melotti in branch '3.3':
    bpo-18798: fix typo in test_fcntl. Patch by Vajrasky Kok.
    http://hg.python.org/cpython/rev/41c90b8f49d9

    New changeset 0f8f5fd6e712 by Ezio Melotti in branch 'default':
    bpo-18798: merge typo fix from 3.3 and also use two unused variables.
    http://hg.python.org/cpython/rev/0f8f5fd6e712

    @ezio-melotti
    Copy link
    Member

    Fixed, thanks for the report and the patch!

    @ezio-melotti ezio-melotti self-assigned this Aug 23, 2013
    @ezio-melotti ezio-melotti added the type-feature A feature request or enhancement label Aug 23, 2013
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant