Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCbuild/readme.txt not up-to-date #63329

Closed
pitrou opened this issue Sep 29, 2013 · 7 comments
Closed

PCbuild/readme.txt not up-to-date #63329

pitrou opened this issue Sep 29, 2013 · 7 comments
Labels
docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@pitrou
Copy link
Member

pitrou commented Sep 29, 2013

BPO 19130
Nosy @loewis, @pitrou, @tiran, @tjguk, @briancurtin, @zware

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-10-01.20:58:29.544>
created_at = <Date 2013-09-29.16:58:41.418>
labels = ['type-bug', 'docs']
title = 'PCbuild/readme.txt not up-to-date'
updated_at = <Date 2013-10-01.20:58:29.542>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2013-10-01.20:58:29.542>
actor = 'pitrou'
assignee = 'docs@python'
closed = True
closed_date = <Date 2013-10-01.20:58:29.544>
closer = 'pitrou'
components = ['Documentation']
creation = <Date 2013-09-29.16:58:41.418>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 19130
keywords = []
message_count = 7.0
messages = ['198602', '198603', '198604', '198605', '198607', '198608', '198807']
nosy_count = 8.0
nosy_names = ['loewis', 'pitrou', 'christian.heimes', 'tim.golden', 'brian.curtin', 'docs@python', 'python-dev', 'zach.ware']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue19130'
versions = ['Python 3.3', 'Python 3.4']

@pitrou
Copy link
Member Author

pitrou commented Sep 29, 2013

PCbuild/readme.txt mentions VS2008 while VS2010 is required to build 3.4. Am I missing something?

@pitrou pitrou added docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error labels Sep 29, 2013
@tiran
Copy link
Member

tiran commented Sep 29, 2013

It also mentions VS 10.0 which is 2010 ... I'm fixing it now.

@tjguk
Copy link
Member

tjguk commented Sep 29, 2013

Nope. Looks like a mistake. Confusingly, the header refers to VC++ 10.0
which is VS 2010 (I think). AFAICT a global s/2008/2010/ would be the
thing to do.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Sep 29, 2013

New changeset 69bb4bf24b07 by Christian Heimes in branch '3.3':
Issue bpo-19130: Correct PCbuild/readme.txt, Python 3.3 and 3.4 require VS 2010
http://hg.python.org/cpython/rev/69bb4bf24b07

New changeset f5a7090e16b7 by Christian Heimes in branch 'default':
Issue bpo-19130: Correct PCbuild/readme.txt, Python 3.3 and 3.4 require VS 2010
http://hg.python.org/cpython/rev/f5a7090e16b7

@python-dev
Copy link
Mannequin

python-dev mannequin commented Sep 29, 2013

New changeset b602edf9b100 by Christian Heimes in branch '3.3':
Issue bpo-19130: mention historic VS 2008 build dir, too
http://hg.python.org/cpython/rev/b602edf9b100

New changeset a16b83ff7fb1 by Christian Heimes in branch 'default':
Issue bpo-19130: mention historic VS 2008 build dir, too
http://hg.python.org/cpython/rev/a16b83ff7fb1

@zware
Copy link
Member

zware commented Sep 29, 2013

bpo-17326 can now be closed as a duplicate of this issue.

@pitrou
Copy link
Member Author

pitrou commented Oct 1, 2013

Thanks Christian!

@pitrou pitrou closed this as completed Oct 1, 2013
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

4 participants